parenthesis get added to v-slot destructuring

[sandros94]

🐛 The bug

CI build log mocking an end user's project

🛠️ To reproduce

https://stackblitz.com/edit/github-mn4exm3e?file=index.js

🌈 Expected behaviour

no parenthesis when destructuring slots

ℹ️ Additional context

As I'm working on nuxt/ui#3479 I've been following along this development in mkdist, altough I do admit it still feels like magick to me.

We heavily rely on typescript both for internal development of Nuxt UI as well as improve DX for those who use the library, so I think this will be a great way to catch any bugs like this one.

I'll try to understand what might be causing it, tho I'm still navigating this repo on-sight

[sandros94]

Found the issue, I should have read this file fully first 🙄

vue-sfc-transformer/src/utils/template.ts

Lines 224 to 242 in fd73275

	async function transformJsSnippet(
	code: string,
	transform: (code: string) => Promise<string>,
	): Promise<string> {
	// `{ key: val } as any` in `<div :style="{ key: val } as any" />` is a valid js snippet,
	// but it can't be transformed.
	// We can warp it with `()` to make it a valid js file
	let res = await transform(`(${code})`)
	res = res.trim()
	// result will be wrapped in `{content};\n`, we need to remove it
	if (res.endsWith(';')) {
	res = res.slice(0, -1)
	}
	return res
	}

[Teages]

I think we need babel to handle this. But I'm worried about speed, I'll do some benchmarks first

[sandros94]

I think we need babel to handle this. But I'm worried about speed, I'll do some benchmarks first

ideally speaking yes, although I was testing something locally and was about to open a PR for a simple workaround for the moment

[sandros94]

Closing this for now