forked from se-edu/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.5rc][F12-B4] HuatAh! #75
Open
jonleeyz
wants to merge
811
commits into
nus-cs2103-AY1718S2:master
Choose a base branch
from
CS2103JAN2018-F12-B4:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 64 commits
Commits
Show all changes
811 commits
Select commit
Hold shift + click to select a range
d157bae
[UI.png] Update screenshot.
jonleeyz ae2e207
Merge pull request #152 from jonleeyz/rebrand
melvintzw df6ffcf
[HtmlWriter.java] improve look of PersonPage for Runner
eencogneeto cf29a86
update user guide
melvintzw 7ac7b29
Improved readability of edit command success message
melvintzw 6cc8d6c
Fix bug where "find w" does not work - where w is an alphanum character
melvintzw 7e3d589
fix bugs where invalid values are provided for interest rate and mone…
melvintzw dde7123
[HtmlWriter.java] additional phone, email, address fields
eencogneeto 1c02cd4
Merge pull request #155 from melvintzw/VariousBugFixes
jonleeyz 08bc89e
Remove ListCommand alias.
jonleeyz 3235b6b
Change LocateCommand alias.
jonleeyz 343e592
Add home ResultDisplay message.
jonleeyz fa1ee10
Change FindCommmand and LocateCommand templates.
jonleeyz 59ad52b
[README.adoc] Update.
jonleeyz c21a702
Update comments for Event classes.
jonleeyz eb85a3a
[AddressBookParserTest.java] Remove JUnit test for ListCommand alias.
jonleeyz 74c9d31
[HtmlWriter.java] modify view for Customer
eencogneeto b756b00
Merge pull request #157 from jonleeyz/templateAndAliases-tweaks
melvintzw a787db6
Improve Locate Command messages
melvintzw 63fc893
[HtmlWriter.java] Modify test
eencogneeto 761b510
Merge branch 'master' of https://github.com/CS2103JAN2018-F12-B4/main…
eencogneeto 9614ff1
Merge pull request #159 from melvintzw/LocateCommandBugFix
eencogneeto 24f5127
Merge branch 'master' of https://github.com/CS2103JAN2018-F12-B4/main…
eencogneeto 81eb375
Merge pull request #160 from Der-Erlkonig/person_page_4
melvintzw a5e8e4a
Modify EditCommandParser and EditCommand to enable editing of Custome…
melvintzw b70b10b
Update UserGuide with edit command enhancement to accept customer-onl…
melvintzw 1bdee5b
Ensure that BrowserPanel reflects most up-to-date Person information
melvintzw 1b5e973
Remove temporarily the assert function for testing the selection of p…
melvintzw 55d1a5a
Merge pull request #161 from melvintzw/EditCommand2
jonleeyz 48ffdef
[UserGuide.adoc] Update LocateCommand entry.
jonleeyz f19cccc
Merge pull request #163 from jonleeyz/UG-locate
melvintzw 5fd9976
Update EditCommand messages
melvintzw 076b5b0
update UG for EditCommand
melvintzw e844807
Improved Email invalid regex message to be slightly more concise and …
melvintzw cf61013
Update UG: known issues
melvintzw c385f3d
Update Portfolio of zhangriqi
9e89694
fix typos
1607bcf
mention ui
a33f777
project management
63cafcc
Merge pull request #164 from melvintzw/Msgs&UG&DG
jonleeyz 3785396
fix trailing space
0fe7282
fix travis error
0b01f57
[HtmlWriter.java] add amount borrowed field for customer to show
eencogneeto 659b9a1
Merge branch 'master' into UpdatePortfolio
jonleeyz ecfc388
Merge branch 'master' into person_page_5
eencogneeto f1b1f73
Merge pull request #166 from Der-Erlkonig/person_page_5
eencogneeto 0731889
Merge branch 'master' into UpdatePortfolio
jonleeyz 3147989
Update Project Portfolio Page
melvintzw 83d21d1
Merge branch 'master' into PPP
melvintzw 4c18507
Merge pull request #165 from zhangriqi/UpdatePortfolio
melvintzw 8e351ad
Merge branch 'master' into PPP
melvintzw b47530b
Update Project, DevGuide
eencogneeto a0455e8
Merge pull request #167 from melvintzw/PPP
eencogneeto 2ecaf81
Merge branch 'master' into PPP_1
eencogneeto a5ff79c
Merge pull request #169 from Der-Erlkonig/PPP_1
melvintzw d165132
Add include:: tags.
jonleeyz 93719ea
[jonleeyz.adoc] Update Project Portfolio Page.
jonleeyz 6b25071
[jonleeyz.adoc] Fix checkstyle violation: no EOF.
jonleeyz 0851764
Merge pull request #170 from jonleeyz/PPP-jonlee
zhangriqi 64e74be
Collate
melvintzw 1e91088
Merge pull request #171 from melvintzw/master
zhangriqi c7243b5
[UserGuide.adoc] Add inline anchors and cross-references.
jonleeyz ee4405d
[UserGuide.adoc] Underline "Usage examples" header.
jonleeyz 7f70c87
[UserGuide.adoc] Add syntax subsections.
jonleeyz 9c9f36d
[UserGuide.adoc] Add sections for remaining commands.
jonleeyz 8fd44ee
Update PPP introduction messages.
jonleeyz 233291b
[UserGuide.adoc] Remove underlines from subsection headers.
jonleeyz 412602f
[UserGuide.adoc] Fix inconsistencies.
jonleeyz 37b51bb
Fix command message inconsistencies.
jonleeyz aad92c0
Change AddCommand alias.
jonleeyz ca4de22
Change AssignCommand alias.
jonleeyz 679ba18
Merge pull request #172 from jonleeyz/documentation-update
melvintzw 522a58a
edit Value Proposition, feature contribution and `delete` test case
melvintzw 40b283c
Improved various portions in the UserGuide
melvintzw 66ed88f
Add some regex tests for XmlAdaptedPerson.toModelType()
melvintzw 3cd401d
in command summary, shifted redo section to after undo section
melvintzw 1f6645b
Merge pull request #174 from melvintzw/Doc_v1.5
jonleeyz 27ef4af
[ClearCommandTest.java] Add test: verifyGetCommandWordWorksCorrectly().
jonleeyz 87247ad
[ListCommandTest.java] Add test: verifyGetCommandWordWorksCorrectly().
jonleeyz f09bb90
[RedoCommandTest.java] Add test: verifyGetCommandWordWorksCorrectly().
jonleeyz e796845
[UndoCommandTest.java] Add test: verifyGetCommandWordWorksCorrectly().
jonleeyz 6aa3c98
[ParserUtilTest.java] Update test implementation: parseAddress_invali…
jonleeyz b080d80
[MoneyBorrowed.java] Rework error messages.
jonleeyz 9f26f6d
[ParserUtil.java] Update implementation: parseMoneyBorrowed().
jonleeyz 398430f
[LateInterest.java] Update implementation of LateInterest class.
jonleeyz c9ea370
[StandardInterest.java] Rework messages.
jonleeyz d03d244
[MoneyBorrowed.java] Rework messages.
jonleeyz 168425e
[ParserUtil.java] Update implementation: parseLateInterest().
jonleeyz 90df6f6
[ParserUtil.java] Update implementation: parseMoneyBorrowed().
jonleeyz 621f624
[ParserUtil.java] Update implementation: parseStandardInterest().
jonleeyz 89942f8
[ParserUtilTest.java] Add tests for parseMoneyBorrowed().
jonleeyz bb7e57e
[ParserUtilTest.java] Add tests for parseStandardInterest().
jonleeyz fabf780
[ParserUtilTest.java] Add tests for parseLateInterest().
jonleeyz d77143c
[ParserUtil.java] Tweak implementation: parseAddress().
jonleeyz e391e2a
[ParserUtilTest.java] Remove dysfunctional test.
jonleeyz e991b27
[ParserUtilTest.java] Fix various checkstyle violations.
jonleeyz 5fa958a
[ParserUtilTest.java] Fix various checkstyle violations.
jonleeyz 998cbf3
Merge pull request #175 from jonleeyz/Tests-ParserAndCommands
jonleeyz daee725
Refactor: PREFIX_MONEYOWED -> PREFIX_MONEY_BORROWED.
jonleeyz bb15e8b
[CommandTestUtil.java] Add new constants.
jonleeyz db83f41
[EditPersonDescriptorBuilder.java] Add test helper methods.
jonleeyz 48453a0
[EditCommandParserTest.java] Update test implementations.
jonleeyz 7f7a610
[ParserUtil.java] Update test method comments.
jonleeyz 279ab8f
[ParserUtilTest.java] Add collate annotation.
jonleeyz 6dd893e
[ParserUtil.java] Update test method signatures.
jonleeyz 48874e2
change first two Customers to Runners.
melvintzw f302750
implement buildRunner()
melvintzw 0724e73
Create JUnit test for assignCommand - unit test seems to work success…
melvintzw ba727bf
[AddressBookSystemTest.java] Move declaration and initialisation of G…
jonleeyz 85d5d57
[AddressBookSystemTest.java] Add new rule: EventsCollectorRule.
jonleeyz ec506ab
[AddCommandSystemTest.java] Reorganise tests.
jonleeyz b461868
[DeleteCommandSystemTest.java] Reorganise tests.
jonleeyz 8367cfc
[EditCommandSystemTest.java] Reorganise tests.
jonleeyz 08da275
[FindCommandSystemTest.java] Reorganise tests.
jonleeyz ddfc33b
[SelectCommandSystemTest.java] Reorganise tests.
jonleeyz 497ed3d
Add check for raising of PopulatePrefixesRequestEvent.
jonleeyz 0c169cf
[HistoryCommandTest.java] Add test: verifyGetCommandWordWorksCorrectl…
jonleeyz 03143fc
Make an error message a psf String
melvintzw 541ebde
Implement two more working test cases (1 valid test case and 1 invali…
melvintzw 0a7e8be
change error message to Messages.MESSAGE_INVALID_PERSON_DISPLAYED_INDEX
melvintzw 0e3b601
Merge branch 'master' of https://github.com/CS2103JAN2018-F12-B4/main…
melvintzw 3df8e8d
change message references
melvintzw 7e45146
[HelpCommandSystemTest.java] Restructure tests.
jonleeyz 38deb69
[EditCommandSystemTest.java] Add comments.
jonleeyz 8c296fc
Fix various checkstyle violations.
jonleeyz ba2a987
Merge pull request #177 from jonleeyz/Tests-ParserAndCommands
melvintzw 6303451
change Runners to the last two persons in the list
melvintzw 6967d37
change runner index to the to refer to the correct runners in Typical…
melvintzw 0dda835
change build type
melvintzw 5a74d83
Merge branch 'master' into JUnitTests
melvintzw 92aacaf
Merge pull request #176 from melvintzw/JUnitTests
jonleeyz 59aa772
Add more JUnit test for Locate Command
566f005
Update ppp
0de735e
Change app name to HuatAh!
4a9bb55
fix failed test
4f5f72a
Merge pull request #180 from zhangriqi/UpdateAppName
melvintzw f61778d
Return error message when locating a person without address.
0a6af0a
locate command JUnit test
fbcea36
Merge branch 'master' into FixLocateCommandBug
melvintzw 53ca34c
Merge pull request #181 from zhangriqi/FixLocateCommandBug
melvintzw 0b0f26a
[CommandBox.java] Implement helper merthods.
jonleeyz 0a329bd
[CommandBox.java] Implement moveToPreviousPrefix().
jonleeyz 6b33599
[CommandBox.java] Implement moveToNextPrefix().
jonleeyz 5742d0d
[CommandBox.java] Implement clearCurrentFieldOrPrefix().
jonleeyz 46091a0
[CommandBox.java] Add method calls.
jonleeyz dd02781
[*Command.java] Made COMAND_TEMPLATE a constant.
jonleeyz 4000ad6
[*CommandSystemTest.java] Update tests to reference constants.
jonleeyz 8d2f5da
[EditCommand.java] Update MESSAGE_USAGE and getCaretIndex().
jonleeyz 21267d4
[CommandBoxHandle.java] Implement helper methods.
jonleeyz f478fb9
[CommandBoxTest.java] Add new tests.
jonleeyz 23ff2aa
[CommandBox.java] Fix checkstyle violations.
jonleeyz 86de31d
Add more tests for LocateCommand
5bbe9ae
Merge pull request #183 from jonleeyz/commandbox-enhancements
zhangriqi d0d28f8
add alias to shortcuts table
eencogneeto 0ef3e35
Merge branch 'master' of git://github.com/CS2103JAN2018-F12-B4/main i…
100be18
clean code
c7c2252
Update project portfolio
08aa870
Merge pull request #179 from zhangriqi/LocateJUnitTest
melvintzw 709e81e
add Customer field oweStartDate
eencogneeto 9d6e2db
add customer field interest rate
eencogneeto e2d0f44
change keyboard shortcut of exit to Alt+Q
eencogneeto d557ba5
edit colours of application (light blue)
eencogneeto 66e8f87
swap email and address lines
eencogneeto 0a609b1
modify test accordingly
eencogneeto b822a0c
Merge branch 'master' into 14April_Afternoon
melvintzw 488d2e9
Merge pull request #184 from Der-Erlkonig/14April_Afternoon
melvintzw 173f66a
hardcoded setStyle() in PersonCard to detemine personCard colour base…
melvintzw e66787b
Merge pull request #185 from melvintzw/newUI
eencogneeto 152835c
change UI screenshot
melvintzw be4a7de
Implement JUnit tests for AssignCommandParser
melvintzw 4a7664f
Implementing AssignCommandSystemTest
melvintzw 036c2d8
Modify AssignCommandSystemTests so that it works (there seems to be a…
melvintzw 39ce87f
Merge pull request #186 from melvintzw/JUnitTests
zhangriqi 0fc8fb5
Merge branch 'master' into newUI
jonleeyz d3af0d6
Merge pull request #187 from melvintzw/newUI
jonleeyz f023485
change list-cell colour to -main-colour
melvintzw 891ee7b
fix unwanted lines in personListPanel
melvintzw 51b7895
Merge pull request #189 from melvintzw/newUI
jonleeyz 56fb75f
Add feature in v2.0
24fe240
Add more AssignCommand JUnit tests
melvintzw 2e0cfc4
Merge pull request #191 from zhangriqi/DocumentationForv2.0
melvintzw 1573652
Merge branch 'master' into JUnitTests
melvintzw 411fd73
Merge pull request #192 from melvintzw/JUnitTests
jonleeyz 782ffef
[CommandBoxTest.java] Reimplement tests.
jonleeyz f49bf1a
[LocateCommandParserTest.java] Add tests.
jonleeyz 8ff1da3
[LocateCommandParserTest.java] Disable 1 test: dysfunctional.
jonleeyz a397c35
Fix checkstyle violations.
jonleeyz d1e29ca
[UniquePersonListTest.java] Add new test: testHashCode_symmetric().
jonleeyz 0282e79
[AddressTest.java] Add new test: testHashCode_symmetric().
jonleeyz a59b7bd
[EmailTest.java] Add new test: testHashCode_symmetric().
jonleeyz 81c3cb8
[NameTest.java] Add new test: testHashCode_symmetric().
jonleeyz 1ff9787
[PhoneTest.java] Add new test: testHashCode_symmetric().
jonleeyz e14d142
[AddressBookTest.java] Add new test: testHashCode_symmetric().
jonleeyz 8a5901b
[AddressBookTest.java] Add new test: removeNonExistentPerson_throwsPe…
jonleeyz a91afd4
[LateInterestTest.java] Add new tests.
jonleeyz a9b3526
[MoneyBorrowedTest.java] Add new tests.
jonleeyz 8e3359a
[StandardInterestTest.java] Add new tests.
jonleeyz 422b3f7
[UserPrefsTest.java] Add new tests.
jonleeyz 9e1eeb4
[SampleDataUtil.java] Remove unused method: defaultDate().
jonleeyz 97b2267
[AddressTest.java] Fix test: testHashcode_symmetric().
jonleeyz 649ed38
[PersonListPanel.java] Add whitespaces.
jonleeyz dc108db
Fix checkstyle violation: rename package Customer to customer.
jonleeyz 2aadcae
[UniquePersonListTest.java] Fix checkstyle violation: remove imports.
jonleeyz c1cff57
[UserPrefsTest.java] Fix checkstyle violation: rename methods.
jonleeyz c21c09f
[SampleDataUtil.java] Fix checkstyle violation: remove import.
jonleeyz 6b96b2c
Merge pull request #193 from jonleeyz/JUnitTests
melvintzw 2f6cc67
Add tests and getter methods to facilitate tests
eencogneeto a6b9856
Update DeveloperGuide
eencogneeto 70e670a
[UI-start.PNG] Add new screenshot.
jonleeyz 4d6cf18
update DevGuide
eencogneeto 447a2c3
[UserGuide.adoc] Update numerous sections.
jonleeyz f17ff2f
[UserGuide.adoc] Add section: Navigation Shortcuts.
jonleeyz 34340d4
Merge branch 'master' of https://github.com/CS2103JAN2018-F12-B4/main…
eencogneeto b18b3a1
Update version to v1.5.
jonleeyz c6eb4cc
[UI_old.jpg] Remove redundant image.
jonleeyz a1b3408
[README.adoc] Update.
jonleeyz 8498728
Correct Test checkstyles, update DevGuide
eencogneeto 1527ac6
Merge pull request #195 from jonleeyz/documentation
melvintzw e34c027
Fix checkstyle
eencogneeto b42d8f9
Merge branch 'master' of git://github.com/CS2103JAN2018-F12-B4/main i…
67fa0f3
Merge branch 'master' into 15April
melvintzw ccae461
Merge pull request #194 from Der-Erlkonig/15April
eencogneeto 4212c43
Update documentation for locate
ae4137c
Update documentation for command alias
7b6c30d
update ppp
c4ba459
[jonleeyz.adoc] Update.
jonleeyz 6370124
[UserGuide.adoc] Update.
jonleeyz 55e3b3a
Add diagrams for FindCommand and Model2
melvintzw 1445118
update various documentation's app version to 1.5
melvintzw eb40c24
update melvintzw PPP
melvintzw f9c61fd
add tags(FindCommandEnhancement, ModelTwo) to DeveloperGuide
melvintzw d638cbd
update devGuide implementation section with Model 2.0
melvintzw b7db38f
Update developer guide
c665d26
PPP and DevGuide
eencogneeto e76ad42
PPP
eencogneeto aeeab19
Merge pull request #197 from melvintzw/Doc_v1.5
jonleeyz 7c0b5d0
Merge branch 'master' into PPP
zhangriqi 1132d4b
Merge branch 'master' into 15_April_2
zhangriqi 7c02508
Merge pull request #198 from Der-Erlkonig/15_April_2
zhangriqi 21dac26
Merge branch 'master' into PPP
zhangriqi 139ba97
Merge pull request #196 from zhangriqi/PPP
melvintzw 2eb741d
include tags in PPP
melvintzw e5d6f4c
Include hyperlinks for examples for bug fix section
melvintzw c93b741
Merge pull request #199 from melvintzw/Doc_v1.5
zhangriqi a326668
Merge branch 'master' into documentation
jonleeyz 7a79f4d
Merge pull request #200 from jonleeyz/documentation
melvintzw 2858988
[DeveloperGuide.adoc] Update.
jonleeyz c4fbe0b
Merge pull request #201 from jonleeyz/documentation-updated
melvintzw 50434db
Change devGuide>implementation>browserPanel image name and width
melvintzw 67b1feb
Merge pull request #202 from melvintzw/master
jonleeyz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update MSS accordingly. I believe you do have new commands which have different workflow.