[W5.11r][T16-B1] Qiu Haoze #769
Open
+95
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsonic
reviewed
Mar 10, 2018
| /** | ||
| * Sorts all persons in the list according to their full name | ||
| */ | ||
| public void sort(){ |
madsonic
reviewed
Mar 10, 2018
| * Sorts all persons in the list according to their full name | ||
| */ | ||
| public void sort(){ | ||
| internalList.sort((person1, person2) -> (person1.getName().fullName.toLowerCase().compareTo( |
There was a problem hiding this comment.
whats the difference between using getName() and fullName?
There was a problem hiding this comment.
getName() gets a Name object, and fullName, a string, is an attribute of class Name.
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sort command to addressbook-level3, with test and documentation updated