From aed3e51fd3b30c6a22a6b1fbc1df9763807b39d1 Mon Sep 17 00:00:00 2001
From: Kun Chen <chenkun0228@gmail.com>
Date: Mon, 17 Apr 2023 11:18:44 -0400
Subject: [PATCH 1/2] fix a critical bug with observables with different types
 for different integrands

---
 src/main.jl        |  6 ++++--
 test/montecarlo.jl | 45 +++++++++++++++++++++++++++++++++++++++++++++
 test/runtests.jl   |  7 +++++++
 3 files changed, 56 insertions(+), 2 deletions(-)

diff --git a/src/main.jl b/src/main.jl
index 733f590..90924b9 100644
--- a/src/main.jl
+++ b/src/main.jl
@@ -123,8 +123,10 @@ function integrate(integrand::Function;
     for iter in 1:niter
 
         for i in 1:Nthread
-            fill!(obsSum[i], zero(obsSum[1][1]))
-            fill!(obsSquaredSum[i], zero(obsSquaredSum[1][1]))
+            for j in eachindex(obsSum[i])
+                obsSum[i][j] = zero(obsSum[i][j])
+                obsSquaredSum[i][j] = zero(obsSquaredSum[i][j])
+            end
             clearStatistics!(summedConfig[i])
         end
 
diff --git a/test/montecarlo.jl b/test/montecarlo.jl
index c6d23f2..4f7abc8 100644
--- a/test/montecarlo.jl
+++ b/test/montecarlo.jl
@@ -47,6 +47,48 @@ function Sphere2(totalstep, alg; offset=0)
     return integrate(integrand; config=config, neval=totalstep, print=-1, solver=alg, debug=true, measure)
 end
 
+# test obs with multiple integrands with different types
+function Sphere3(totalstep, alg; offset=0)
+    function integrand(X, config) # return a tuple of two integrands
+        i1 = (X[1+offset]^2 + X[2+offset]^2 < 1.0) ? 1.0 : 0.0
+        i2 = (X[1+offset]^2 + X[2+offset]^2 + X[3+offset]^2 < 1.0) ? 1.0 : 0.0
+        return i1, i2
+    end
+    function integrand(idx, X, config) # return one of the integrand
+        @assert idx == 1 || idx == 2 "$(idx) is not a valid integrand"
+        if idx == 1
+            return (X[1+offset]^2 + X[2+offset]^2 < 1.0) ? 1.0 : 0.0
+        else
+            return (X[1+offset]^2 + X[2+offset]^2 + X[3+offset]^2 < 1.0) ? 1.0 : 0.0
+        end
+    end
+
+    function measure(X, obs, relativeWeights, config)
+        obs[1] += relativeWeights[1]
+        obs[2][1] += relativeWeights[2]
+        obs[2][2] += relativeWeights[2] * 2.0
+    end
+    function measure(idx, X, obs, relativeWeight, config)
+        if idx == 1
+            obs[idx] += relativeWeight
+        elseif idx == 2
+            obs[idx][1] += relativeWeight
+            obs[idx][2] += relativeWeight * 2.0
+        else
+            error("invalid idx: $(idx)")
+        end
+    end
+
+    T = Continuous(0.0, 1.0; offset=offset)
+    # dof = [2 3] # a 1x2 matrix, each row is the number of dof for each integrand
+    dof = [[2,], [3,]] # a 1x2 matrix, each row is the number of dof for each integrand
+    obs = [0.0, [0.0, 0.0]]
+    config = Configuration(var=(T,), dof=dof; neighbor=[(1, 3), (1, 2)], obs=obs)
+    @inferred integrand(config.var[1], config) #make sure the type is inferred for the integrand function
+    @inferred integrand(1, config.var[1], config) #make sure the type is inferred for the integrand function
+    return integrate(integrand; config=config, neval=totalstep, print=-1, solver=alg, debug=true, measure)
+end
+
 function TestDiscrete(totalstep, alg)
     X = Discrete(1, 3, adapt=true)
     dof = [[1,],] # number of X variable of the integrand
@@ -153,6 +195,7 @@ end
     println("Sphere 2D + 3D")
     check(Sphere2(neval, :mcmc), [π / 4.0, 4.0 * π / 3.0 / 8])
     check(Sphere2(neval, :mcmc; offset=2), [π / 4.0, 4.0 * π / 3.0 / 8])
+    check_vector(Sphere3(neval, :mcmc), [π / 4.0, [4.0 * π / 3.0 / 8, 4.0 * π / 3.0 / 4]])
     println("Discrete")
     check(TestDiscrete(neval, :mcmc), 6.0)
     println("Singular1")
@@ -183,6 +226,7 @@ end
     println("Sphere 2D + 3D")
     check(Sphere2(neval, :vegas), [π / 4.0, 4.0 * π / 3.0 / 8])
     check(Sphere2(neval, :vegas; offset=2), [π / 4.0, 4.0 * π / 3.0 / 8])
+    check_vector(Sphere3(neval, :vegas), [π / 4.0, [4.0 * π / 3.0 / 8, 4.0 * π / 3.0 / 4]])
     println("Discrete")
     check(TestDiscrete(neval, :vegas), 6.0)
     println("Singular1")
@@ -220,6 +264,7 @@ end
     println("Sphere2 with offset")
     check(Sphere2(neval, :vegasmc; offset=2), [π / 4.0, 4.0 * π / 3.0 / 8])
     # check(Sphere3(neval), [π / 4.0, 4.0 * π / 3.0 / 8])
+    check_vector(Sphere3(neval, :vegasmc), [π / 4.0, [4.0 * π / 3.0 / 8, 4.0 * π / 3.0 / 4]])
     println("Discrete")
     check(TestDiscrete(neval, :vegasmc), 6.0)
     println("Singular1")
diff --git a/test/runtests.jl b/test/runtests.jl
index 22d2165..2affa86 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -14,6 +14,13 @@ function check(result::Result, expect, ratio=7.0)
     check(mean, error, expect, ratio)
 end
 
+function check_vector(result::Result, expect, ratio=7.0)
+    mean, error = result.mean, result.stdev
+    for ei in eachindex(expect)
+        check(mean[ei], error[ei], expect[ei], ratio)
+    end
+end
+
 function check_complex(result::Result, expect, ratio=7.0)
     mean, error = result.mean, result.stdev
     # println(mean, error)

From f0b9470bd895a7443de9e5863042fc8950723599 Mon Sep 17 00:00:00 2001
From: Kun Chen <chenkun0228@gmail.com>
Date: Mon, 17 Apr 2023 11:28:33 -0400
Subject: [PATCH 2/2] add output for comparison

---
 test/runtests.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/runtests.jl b/test/runtests.jl
index 2affa86..816095b 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -2,7 +2,7 @@ using MCIntegration
 using Test
 
 function check(mean, error, expect, ratio=7.0)
-    # println(mean, error)
+    println("mean = $mean, error = $error with expected value = $expect")
     for ei in eachindex(expect)
         @test abs(mean[ei] - expect[ei]) < error[ei] * ratio
     end