New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't match getty on bad uri with colon at start of string #179

Merged

kdid merged 1 commit into main from 5304-bad-uri

Dec 12, 2024

Contributor

kdid commented Dec 12, 2024 •

edited

Loading

Getty was matching a uri with a colon at the start of the string. For example: :http://id.loc.gov/authorities/names/no2009091821 and then timing out trying to preform the fetch.
This should produce an {:error, :unknown_authority} instead

Note: I debated dealing with this more globally then decided against it. But open to suggestions.


          Don't match getty on bad uri with colon at start of string

82686fa

mbklein self-requested a review

December 12, 2024 19:23

mbklein approved these changes

View reviewed changes

kdid self-assigned this

kdid merged commit d94e200 into main

7 checks passed

kdid deleted the 5304-bad-uri branch

December 12, 2024 19:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet