Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tray menu options now have translations when a user changes their lan… #1545

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

maxx-niu
Copy link
Contributor

changes to traymenu only apply after a language change is issued from the settings. Not sure how to apply the translations with the configure language when the app launches

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4c84ecc) 71.41% compared to head (a1e9095) 71.40%.

Files Patch % Lines
packages/app/app/components/Settings/index.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1545      +/-   ##
==========================================
- Coverage   71.41%   71.40%   -0.02%     
==========================================
  Files         364      364              
  Lines        6706     6707       +1     
  Branches      479      479              
==========================================
  Hits         4789     4789              
- Misses       1523     1524       +1     
  Partials      394      394              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nukeop
Copy link
Owner

nukeop commented Jan 31, 2024

Thanks, looks good!

@nukeop nukeop merged commit 759c6b7 into nukeop:master Jan 31, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants