Deprecate no longer supported formats

nukeop · Mar 6, 2024 · c61a4cc · c61a4cc
1 parent ae45d93
commit c61a4cc
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 27 deletions.
diff --git a/package.json b/package.json
@@ -117,29 +117,13 @@
         "ext": "opus",
         "mimeType": "audio/ogg"
       },
-      {
-        "ext": "aac",
-        "mimeType": "audio/aac"
-      },
       {
         "ext": "flac",
         "mimeType": "audio/flac"
       },
-      {
-        "ext": "wav",
-        "mimeType": "audio/x-wav"
-      },
-      {
-        "ext": "weba",
-        "mimeType": "audio/weba"
-      },
       {
         "ext": "mp4",
         "mimeType": "audio/mp4"
-      },
-      {
-        "ext": "webm",
-        "mimeType": "audio/webm"
       }
     ],
     "linux": {

diff --git a/packages/scanner/src/metadata.rs b/packages/scanner/src/metadata.rs
@@ -1,13 +1,12 @@
-use std::{fs::File, io::BufReader};
+use std::fs::File;
 
 use derive_builder::Builder;
 use id3::TagLike;
 use metaflac;
 use symphonia::core::{
-    codecs::DecoderOptions,
     formats::FormatOptions,
     io::MediaSourceStream,
-    meta::{MetadataOptions, MetadataRevision, StandardTagKey},
+    meta::{MetadataOptions, StandardTagKey},
     probe::Hint,
 };
 
@@ -191,7 +190,6 @@ impl MetadataExtractor for OggMetadataExtractor {
         if let Some(meta) = probed.format.metadata().current() {
             for tag in meta.tags().iter() {
                 if tag.is_known() {
-                    println!("{:?}", tag.std_key);
                     match tag.std_key {
                         Some(StandardTagKey::TrackTitle) => {
                             metadata.title = Some(tag.value.to_string());

diff --git a/packages/scanner/src/scanner.rs b/packages/scanner/src/scanner.rs
@@ -1,14 +1,14 @@
 use id3::{Error, Tag};
-use std::collections::{HashSet, LinkedList};
+use std::collections::LinkedList;
 use std::ffi::OsStr;
 use std::path::Path;
 use uuid::Uuid;
 
 use crate::error::{MetadataError, ScannerError};
 use crate::local_track::LocalTrack;
 use crate::metadata::{
-    AudioMetadata, AudioMetadataBuilder, FlacMetadataExtractor, MetadataExtractor,
-    Mp3MetadataExtractor, Mp4MetadataExtractor, OggMetadataExtractor,
+    AudioMetadata, FlacMetadataExtractor, MetadataExtractor, Mp3MetadataExtractor,
+    Mp4MetadataExtractor, OggMetadataExtractor,
 };
 
 pub trait TagReader {
@@ -80,6 +80,8 @@ pub fn visit_directory(
 
 #[cfg(test)]
 mod tests {
+    use crate::metadata::AudioMetadataBuilder;
+
     use super::*;
 
     #[derive(Debug, Clone, Default)]
@@ -112,7 +114,7 @@ mod tests {
                 .duration(10)
                 .position(1)
                 .disc(1)
-                .year(2020)
+                .year("2020".to_string())
                 .thumbnail("http://localhost:8080/thumbnails/0b/0b0b0b0b0b0b0b0b.webp".to_string())
                 .build()
                 .unwrap(),
@@ -122,8 +124,7 @@ mod tests {
     #[test]
     fn test_visit_file() {
         let path = "tests/test.mp3".to_string();
-        let thumbnails_dir = "tests/thumbnails".to_string();
-        let mut created_thumbnails_hashset: HashSet<String> = HashSet::new();
+        let thumbnails_dir: String = "tests/thumbnails".to_string();
         let local_track = visit_file(path, test_extractor_from_path, &thumbnails_dir).unwrap();
         assert_eq!(local_track.filename, "test.mp3");
         assert_eq!(local_track.metadata.artist, Some("Test Artist".to_string()));
@@ -132,7 +133,7 @@ mod tests {
         assert_eq!(local_track.metadata.duration, Some(10));
         assert_eq!(local_track.metadata.position, Some(1));
         assert_eq!(local_track.metadata.disc, Some(1));
-        assert_eq!(local_track.metadata.year, Some(2020));
+        assert_eq!(local_track.metadata.year, Some("2020".to_string()));
         assert_eq!(
             local_track.metadata.thumbnail,
             Some("http://localhost:8080/thumbnails/0b/0b0b0b0b0b0b0b0b.webp".to_string())