fix: Add serial number (#62)

Use device id as unique serial number for the device
nt0xa · Jan 19, 2021 · 85db74a · 85db74a
1 parent 0b9f529
commit 85db74a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/devices/factory.ts b/src/devices/factory.ts
@@ -68,7 +68,7 @@ export async function createHumidifier(
 
   return new BaseHumidifier(
     protocol,
-    [...feat.accessoryInfo(model), ...feats],
+    [...feat.accessoryInfo(model, device.id), ...feats],
     new Logger(log, `[${address}] `),
   );
 }

diff --git a/src/devices/features.ts b/src/devices/features.ts
@@ -18,6 +18,7 @@ export type AnyCharacteristicConfig<PropsType> = CharacteristicConfig<
 export interface Features<PropsType extends BasePropsType> {
   accessoryInfo(
     model: HumidifierModel,
+    deviceId: number,
   ): Array<AnyCharacteristicConfig<PropsType>>;
 
   currentState<PropKey extends keyof PropsType>(
@@ -128,7 +129,7 @@ export function features<PropsType extends BasePropsType>(
   log: hb.Logging,
 ): Features<PropsType> {
   return {
-    accessoryInfo(model) {
+    accessoryInfo(model, deviceId) {
       return [
         {
           service: Service.AccessoryInformation,
@@ -140,6 +141,11 @@ export function features<PropsType extends BasePropsType>(
           characteristic: Characteristic.Model,
           value: model,
         },
+        {
+          service: Service.AccessoryInformation,
+          characteristic: Characteristic.SerialNumber,
+          value: `${deviceId}`,
+        },
       ];
     },