Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add styles exports #9

Closed
meteorlxy opened this issue Dec 31, 2023 · 0 comments · Fixed by #10
Closed

[feature] add styles exports #9

meteorlxy opened this issue Dec 31, 2023 · 0 comments · Fixed by #10
Assignees
Labels
enhancement New feature or request

Comments

@meteorlxy
Copy link

What is the problem that this feature enhancement aims to solve?

As the docs said:

The styles and variables can be imported from ../node_modules/data-grid-vue/dist/style.css

It looks a little bit strange.

Describe the solution you'd like

Maybe we can add an extra export for style file, e.g.

{
  "exports": {
    "./style": "./dist/style.css"
  }
}

Then users can import the style from 'data-grid-vue/style'

@meteorlxy meteorlxy added the enhancement New feature or request label Dec 31, 2023
@nruffing nruffing linked a pull request Jan 13, 2024 that will close this issue
nruffing added a commit that referenced this issue Jan 13, 2024
* add styles as a package export for easier referencing - closes #9

* update dragon-drop-vue and replace window resize debounce with native-event-vue

* update dev dependencies

* Fix bug in  where paging through a sorted grid could cause data to not stay sorted.

* setup vitest

* v3.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants