Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Liquidjs Filters tooltip NV-5235 #7561

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

scopsy
Copy link
Contributor

@scopsy scopsy commented Jan 22, 2025

What changed? Why was the change needed?

  • Help with explaining the nature of piped filters on the variable pill

Screenshots

CleanShot 2025-01-22 at 17 23 33@2x
CleanShot 2025-01-22 at 17 23 29@2x

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit f06f862
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/67910d86266fdc0007f5df20
😎 Deploy Preview https://deploy-preview-7561.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit f06f862
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/67910d864cff5d000882818f
😎 Deploy Preview https://deploy-preview-7561.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@scopsy scopsy changed the title feat(dashboard): Liquidjs Filters tooltip feat(dashboard): Liquidjs Filters tooltip NV-5235 Jan 22, 2025
Copy link

linear bot commented Jan 22, 2025

</TooltipTrigger>
<TooltipContent side="right" className="max-w-sm">
<p>
LiquidJS filters are functions that modify the output of your variables. They are applied in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

LiquidJS filters are functions that modify the variable output, 
applying each in sequence where one filter's result feeds into the next. 
Example: {{ name | capitalize | append: "!" }}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the example adds value, because it's just the expression, without the impact of pipes order, etc… I do like the shorter term tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants