Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): Crate with UI fixes #7536

Merged
merged 14 commits into from
Jan 23, 2025
Merged

fix(dashboard): Crate with UI fixes #7536

merged 14 commits into from
Jan 23, 2025

Conversation

SokratisVidros
Copy link
Contributor

@SokratisVidros SokratisVidros commented Jan 17, 2025 •
edited
Loading

What changed? Why was the change needed?

Pixel perfect implementation of the step editors

The fixes include:

  • Teach Codemirror to look and behave exactly like the rest of native HTML inputs regarding focus, rendering with errors, and overflowing with long content (text-wrapping).
  • Simplify the CSS logic of the variable pills and ensure they are not causing any jumps to the hosting editor.
  • Polish in-app action buttons.
  • Use simpler markup to render ControlInputs.
  • Apply copywriting fixes
  • Add client-side validation to the step creation form to behave exactly like the workflow creation form.
  • Fix invalid HTML markup; we were rendering nested buttons on multiple occasions.
  • Fix error state rendering for the Avatar Picker
  • Perfect Variable popover placement for multiline <ControlInput/>. Now that the editor occupies all the available space, the popover opens relative to the full box of the editor, so it's a bit further down than we want.

Screenshots

It's too late for so many screenshots. I advise reviewers to open the preview deployment next to the latest production deployment and test.

@SokratisVidros SokratisVidros self-assigned this Jan 17, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit bcabb6f
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6792b30508f9f10008719a59
😎 Deploy Preview https://deploy-preview-7536.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit bcabb6f
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/6792b3051dd9ff0008e8a53e
😎 Deploy Preview https://deploy-preview-7536.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

scopsy
scopsy approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

SokratisVidros and others added 13 commits January 23, 2025 16:27
@SokratisVidros
fix(dashboard): Apply client side validation to step creation form
0ba4871
@SokratisVidros
fix(dashboard): Pixel perfect in-app editor
98ca620
@SokratisVidros
fix(dashboard): Align email subject with the new api.
00d0179
@SokratisVidros
fix(dashboard): Pixel perfect sms, chat, push
98afc24
@SokratisVidros
fix(api): Polish error messages
7977331
@SokratisVidros
fixup! fix(dashboard): Pixel perfect in-app editor
2eb3e10
@SokratisVidros
fix(dashboard): More touch-ups
8bbe4b3
@SokratisVidros @scopsy
Update apps/dashboard/src/components/primitives/editor.tsx
71a54cc 
Co-authored-by: Dima Grossman <dima@grossman.io>
@SokratisVidros @scopsy
Update apps/dashboard/src/components/primitives/control-input/control…
d401cb4 
…-input.tsx

Co-authored-by: Dima Grossman <dima@grossman.io>
@SokratisVidros @scopsy
Update apps/dashboard/src/components/primitives/editor.tsx
636be07 
Co-authored-by: Dima Grossman <dima@grossman.io>
@SokratisVidros
Update build-step-issues.usecase.ts
406ba4b
@SokratisVidros
Update editor.tsx
f3dd593
@SokratisVidros
Update control-input.tsx
f28a8bc
@SokratisVidros SokratisVidros merged commit f274fcf into next Jan 23, 2025
32 checks passed
@SokratisVidros SokratisVidros deleted the crate_with_ui_fixes branch January 23, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scopsy scopsy scopsy approved these changes

@LetItRock LetItRock Awaiting requested review from LetItRock

@desiprisg desiprisg Awaiting requested review from desiprisg

Assignees

@SokratisVidros SokratisVidros

Labels
@novu/api-service @novu/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SokratisVidros @scopsy