Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHS shouldn't give diagonal points #319

Merged
merged 1 commit into from
Feb 13, 2025
Merged

LHS shouldn't give diagonal points #319

merged 1 commit into from
Feb 13, 2025

Conversation

SRFU-NN
Copy link
Collaborator

@SRFU-NN SRFU-NN commented Feb 13, 2025

This was the reason why LHS gave diagonal points

LHS before:
image

LHS after:
image

This was the reason why LHS gave diagonal points
@SRFU-NN SRFU-NN changed the title fix: Sampling multiple points work LHS shouldn't give diagonal points Feb 13, 2025
@SRFU-NN SRFU-NN merged commit 7b4672b into develop Feb 13, 2025
6 checks passed
@SRFU-NN SRFU-NN deleted the LHS_diagonal branch February 13, 2025 09:24
@dk-teknologisk-mon
Copy link
Collaborator

This felt a bit rushed to me and I do not see why/how this was a bug. Before this change, LHS does not give linearly correlated points, so I assume the above is some edge case caused by something else?

from ProcessOptimizer import Optimizer
space = [(0.0, 1.0), (0.0, 1.0)]

opt = Optimizer(
    dimensions=space,
    lhs=True,
    n_initial_points=5,
    random_state=42,
)

x = opt.ask(5)

This code returns these points:
image

@SRFU-NN
Copy link
Collaborator Author

SRFU-NN commented Feb 13, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants