Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Improve android build #2439

Merged
merged 3 commits into from
Feb 25, 2025
Merged

build: Improve android build #2439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0668746
build: Improve android build
valentunn Feb 24, 2025
444f7d2
build: bump rust plugin version
valentunn Feb 24, 2025
6e6fb28
Merge branch 'master' into chore/android_build
valentunn Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Any data transfer from or to the app happens using QR code. By doing so, the mos

Please read our documentation before using Vault for the first time or before upgrading. It covers the main use-cases such as installing on a new phone, creating keys, upgrading and adding new networks:

👉 https://docs.novawallet.io/nova-wallet-wiki/wallet-management/hardware-wallets/polkadot-vault
👉 https://docs.novawallet.io/nova-wallet-wiki/wallet-management/hardware-wallets/polkadot-vault

# Project Structure

Expand Down Expand Up @@ -154,6 +154,16 @@ Enable "Show package details" checkmark to select specific version.

**10.** Run the project (`Ctrl+R`). It should build the Rust core library automatically.

### Troubleshooting

#### "no such file or directory" error when invoking cargo/rustc/uniffi-bindgen
1. Ensure rust and uniffi-bindgen are installed
2. Sometimes launching Android Studio from the Finder might result in Android Studio not seeing all env needed variables
Try launching Studio from the shell (command assumes you are in the "Applications" folder)
```shell
./Android\ Studio.app/Contents/MacOS/studio
```

# Release Android

- Create PR with new app version updated
Expand Down
4 changes: 2 additions & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ buildscript {
maven { url "https://plugins.gradle.org/m2/" }
}
dependencies {
classpath 'com.android.tools.build:gradle:8.2.0'
classpath 'com.android.tools.build:gradle:8.2.2'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath "org.mozilla.rust-android-gradle:plugin:0.9.3"
classpath "org.mozilla.rust-android-gradle:plugin:0.9.6"
// uniffi wants some build-time specific info from JNA
classpath 'net.java.dev.jna:jna:5.12.1'
// NOTE: Do not place your application dependencies here; they belong
Expand Down
Loading