Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build workflow #2434

Merged
merged 34 commits into from
Feb 20, 2025
Merged

fix: build workflow #2434

merged 34 commits into from
Feb 20, 2025

Conversation

stepanLav
Copy link
Member

@stepanLav stepanLav commented Feb 11, 2025 •
edited
Loading

Changes in this PR

Dependencies Updates

  • Fixed Parity libraries version to tag "monthly-2023-05" due to repository archival
  • Updated OpenCV to version 0.93 (tried on older version up to 0.83, but can't be built)
  • Updated deny crate version as the older version couldn't be configured correctly

Code Quality Improvements

  • Fixed Rust Clippy warnings across the codebase
  • Fixed code formatting issues

CI/CD

  • Made some improvements to GitHub Actions workflow files

Technical Details

  • Implemented different interfaces for cvt_color on Linux/macOS platforms due to errors, described it in the code comment
  • All Clippy warnings have been addressed with corresponding fixes

Semantic fix moved to separate PR:

@stepanLav stepanLav force-pushed the fix/ci_build branch 2 times, most recently from 575484f to 030f2f1 Compare February 12, 2025 09:02
@stepanLav
fix: rust build
1ff40ae 
fix token usage

fix: return events back

fix: dependencies

update list of deny

rollback rust

fix: try to use particullar version

return stable back

fix: add test default

fix tiny

disable cache

disable cache

fix: qr reader phone

fix: qr_reader

use target_os

fix: cargo clippy

fix: fmt

fix: remove semantic changes

fix: remove semantic changes
@stepanLav
fix: clippy
3229deb 
fix: clippy

fix: clippy

fix: clippy

fix: clippy
@stepanLav
fix: redundant decrease
68f7ad4
@stepanLav
fix: workflows
0356fff 
fix: ations
@stepanLav
fix: clippy
e19cd84 
fix clippy

fix clippy
@stepanLav stepanLav changed the title Fix: build workflow fix: build workflow Feb 14, 2025
@stepanLav stepanLav requested a review from ERussel February 14, 2025 06:23
ERussel
ERussel reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@ERussel ERussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The iOS E2E tests are failing because are being run using XCode 15. We need to move to XCode 16

@stepanLav stepanLav requested a review from krodak as a code owner February 17, 2025 18:22
stepanLav and others added 2 commits February 18, 2025 18:24
@stepanLav
downgrade ubuntu
ee365fd
@stepanLav
fix: use latest opencv on ubuntu (#2437)
815e593 
* fix: use latest opencv on ubuntu

* feat: add using opencv dockerfile

* trigger event

* remove test trigger

* use builded container

* rebuild image

* update build image

* debug

* swithc to root

* fix install dep

* fix source

* fix dependency

* fix dependency

* fix: dependency

* build new image version

* fix source

* fix: build errors

* fix: install dep

* fix: dependency

* fix: dependency

* fix dependency

* fix: remove sudo command

* fix dependency in doc

* fix: update opencv version

* fix: update opencv

* fix: decrease repetition

* try to use action

* use fixed version

* fix version format
@stepanLav stepanLav merged commit 695dccc into fix/xcode16-build Feb 20, 2025
11 checks passed
@stepanLav stepanLav deleted the fix/ci_build branch February 20, 2025 10:11
ERussel added a commit that referenced this pull request Feb 20, 2025
@ERussel @krodak
@stepanLav @valentunn
fix: xcode16 build (#2429)
905506c 
* feat: ios: update tos and pp files

* chore: ios: update Fastlane configuration

* Test build (#2425)

* Revert "chore(deps): bump raptorq from 1.8.1 to 2.0.0 in /rust (#2372)"

This reverts commit d31f553.

* fix: allow ded_code

* fix: permission for semantic workflow

* fix: clippy

* fix: change semantic permission to write

* fix: change token usage

* fix: pull_request event

* fix: add concurency

* fix: add actor

* fix: lint problem

* fix: change signing cecrt

* fix: change appfile

* change team id

* fix: semantic triggers

* fix: change actors

* fix: remove unnecessary changes

* fix: return semantic run back

* fix: temp add stepanLav

---------

Co-authored-by: valentunn <70131744+valentunn@users.noreply.github.com>

* fix: XCode 16 build

* fix: fix opencv library update

* fix warning

* linting

* fix: build workflow (#2434)

* fix: dependencies

* fix: upload-artifacts

* fix deny

* fix manifest path

* fix: semantic permissions

* fix: use app instead of github token

* fix: update version

* fix: rust build

fix token usage

fix: return events back

fix: dependencies

update list of deny

rollback rust

fix: try to use particullar version

return stable back

fix: add test default

fix tiny

disable cache

disable cache

fix: qr reader phone

fix: qr_reader

use target_os

fix: cargo clippy

fix: fmt

fix: remove semantic changes

fix: remove semantic changes

* fix: clippy

fix: clippy

fix: clippy

fix: clippy

fix: clippy

* fix: redundant decrease

* fix: workflows

fix: ations

* fix: versions

* fix cargo.lock

* fix: return small fixes back

* fix: deny config

* fix: clippy

fix clippy

fix clippy

* fix: rollback version to ref

* fix: deny

* fix: macos version

* downgrade opencv

* fix: remove cache

* fix: update opencv usage

* fix: fmt

* fix version in actions

* fix: spellcheck

* fix build script

* fix: build version for ios

* fix: return target_os definition

* fix: rollback ubuntu version

* make directory writable

* downgrade ubuntu

* fix: use latest opencv on ubuntu (#2437)

* fix: use latest opencv on ubuntu

* feat: add using opencv dockerfile

* trigger event

* remove test trigger

* use builded container

* rebuild image

* update build image

* debug

* swithc to root

* fix install dep

* fix source

* fix dependency

* fix dependency

* fix: dependency

* build new image version

* fix source

* fix: build errors

* fix: install dep

* fix: dependency

* fix: dependency

* fix dependency

* fix: remove sudo command

* fix dependency in doc

* fix: update opencv version

* fix: update opencv

* fix: decrease repetition

* try to use action

* use fixed version

* fix version format

* allow arm64 and build libsigner based on platform

* rollback building

---------

Co-authored-by: Russel <emkil.russel@gmail.com>

* fix: Password intersection with borders when importing keyset via banana split (#2430)

* feat: add custom modifier for plain text field

* refactor

* fix: missing filter missing in the empty state (#2432)

* feat: add custom modifier for plain text field

* refactor

* fix: display header with filter button in the empty state

* refactor into separate extensions

---------

Co-authored-by: Krzysztof Rodak <krodak.konta@gmail.com>
Co-authored-by: Krzysztof Rodak <krzysztof@parity.io>
Co-authored-by: Stepan Lavrentev <40560660+stepanLav@users.noreply.github.com>
Co-authored-by: valentunn <70131744+valentunn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ERussel ERussel ERussel approved these changes

@krodak krodak Awaiting requested review from krodak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepanLav @ERussel