[FEAT] lowpass filter #6
Conversation
|
Also for hacktoberfest, I believe the topic assigned to the repo should be "hacktoberfest" instead of "hacktoberfest2024" |
Hm i see, ill just add both as topics then |
I tried seeing the difference between the current commit of rAVen and your PR with a variety of music files and havent seemed to find a major difference I have looked at your comments (appreciate you using my commenting style btw lol) and it seems good to go, but while testing i didnt notice a lot of difference in the visualization being more smooth So it would be great if you could explain the changes behind low pass filter and how it is supposed to work in real time (if a video demonstrating the changes is not possible its fine) |
|
Any updates on the video or explanation? |
|
Yes, sorry. I set the default cutoff frequency to a very high number, since I didn't know what frequencies you wanted to cut out. Changing the last parameter in the apply_low_pass_filter function call located in fft function from 99999.0f to something like 50000.0f or 45000.0f will show you a difference. From there its just about dialing in what the right cutoff should be. |
|
Also in terms of explanation, is there anything more that you would like to know that's not included in the comments? |
| @@ -157,6 +184,8 @@ void fft(float in[], size_t stride, float complex out[], size_t n) | |||
| out[k] = e + v; | |||
| out[k + n / 2] = e - v; | |||
| } | |||
|
|
|||
| apply_low_pass_filter(out, n, sample_rate, 99999.0f); | |||
There was a problem hiding this comment.
Tweaking this line will change the graphics produced!
Nah not necessary the above comment should be good enough |
the frequencies i want to cut out is outside the range of human hearing so ensuring that we only visualize in the range of 20hz-20khz should suffice |
So if you manage to cutoff frequencies that dont match this range, that would be amazing |
|
Ok it sounds like what you want is a band pass filter, (both high pass and low pass). I will have to go back and do some research/re implement functionality to make that work. |
Yes that would be great 👍 And do continue using the commenting style to explain the newly added functions logic and implementation :) |
|
Hey there any progress on this? |
resolves #2
I am currently working on the video, and will provide mathematical implementation details shortly as well.