Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a low pass filter #2

Open
nots1dd opened this issue Oct 3, 2024 · 6 comments · May be fixed by #6
Open

adding a low pass filter #2

nots1dd opened this issue Oct 3, 2024 · 6 comments · May be fixed by #6
Labels
hacktoberfest Issues for hacktoberfest2024

Comments

@nots1dd
Copy link
Owner

nots1dd commented Oct 3, 2024

Some frequencies are quite sharp and unnecessary to visualize, they need to be filtered out

You can check online implementations and logic behind this

@nots1dd nots1dd added the hacktoberfest Issues for hacktoberfest2024 label Oct 3, 2024
@joeypas
Copy link

joeypas commented Oct 4, 2024

Hello!
I'd like to work on this issue, I just have a couple questions.

  1. Would you like this to be an option, or the default? If an option, should it be applied through a command?
  2. For the 2 required parameters for a low pass filter (sample rate, cutoff frequency), should these be constants, or also applied as an option through some sort of command?

@nots1dd
Copy link
Owner Author

nots1dd commented Oct 5, 2024

@joeypas
Hi!
Sure you can work on this issue, but my friend already seems to have implemented it and may be adding a PR soon.

Would you still like to work on this issue? (I am creating other issues now btw)

@joeypas
Copy link

joeypas commented Oct 5, 2024

I believe I have also implemented a solution, I just wanted to check what the specific requirements were. If you provide that context I would be happy to quickly update my code and submit a pr. Thanks!

@joeypas
Copy link

joeypas commented Oct 5, 2024

Yes I would like to work on it if possible!

@nots1dd
Copy link
Owner Author

nots1dd commented Oct 5, 2024

@joeypas

Sure you can work on this issue no problem

I do not have a CONTRIBUTION.md setup for this project yet but make sure there are not many drastic changes in your PR

Also do explain the maths and logic behind your implementation of the same :)

It is also recommended that you send a video of its working so I can get a bit more visual understanding of the solution

You can also look at other issues if you feel interested, thanks for showing interest in my project!

@nots1dd
Copy link
Owner Author

nots1dd commented Oct 5, 2024

Hello! I'd like to work on this issue, I just have a couple questions.

1. Would you like this to be an option, or the default? If an option, should it be applied through a command?

2. For the 2 required parameters for a low pass filter (sample rate, cutoff frequency), should these be constants, or also applied as an option through some sort of command?
  1. This would need to be there by default
  2. For now let them be constants, currently I am working on getting real time audio samples from multimedia frameworks like pipewire, when that is integrated or reaches some form of maturity, will decide on this part then

Sample rate if am not wrong, can be taken from raylib's struct Music itself, it should look like this:

Music music // declaration of raylib's music struct

/* existing code */

music.stream.sampleRate (returns string) // call this to get the current song's sample rate

@joeypas joeypas linked a pull request Oct 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues for hacktoberfest2024
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants