-
Notifications
You must be signed in to change notification settings - Fork 8
Authors field in the highlights data should be an array #104
Comments
Ack. This falls under design space for interactivity with a highlight:
|
My thoughts on your questions:
@adamjonas @aassoiants can provide more insights/thoughts on this |
Wouldn't one author for each highlight be simpler? This is probably going to make things easier when you follow a list of people right? Another con would be that if you merge authorship you lose time stamps when an author made the timestamp. |
The flow I have in mind is this -> each highlight is saved independently but is referenced by an author. So to know which highlights belongs to an author, we fetch the highlights that has the author's name/pubkey/id in the author array field. This also helps to fetch all highlight without taling into consideration the authors field since we have a "all highlights" button in the UI. Design wise, this introduces separation of concerns and is much easier in my opinion to map authors and highlights together both on the frontend and backend. |
@Extheoisah I'd defer this for post MVP1. It would require a data model redesign, and of course we'd be better informed by user expectations and requirements. |
Sounds good. I'll label this as a 1.5 issue |
Currently, the authors field in the highlights data returned from collab is a string. Instead it should be an array of strings(authors) so as to accommodate other authors that may have highlighted the same text. cc @nully0x @okjodom
The text was updated successfully, but these errors were encountered: