Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more gamedata support for other #8

Open
HotoCocoaco opened this issue Dec 3, 2022 · 1 comment
Open

Add more gamedata support for other #8

HotoCocoaco opened this issue Dec 3, 2022 · 1 comment

Comments

@HotoCocoaco
Copy link

Gamedata support.

Further future.

Just make every tf2 plugin author use tf2utils and submit their gamedata file with pull request.

@nosoop
Copy link
Owner

nosoop commented Dec 3, 2022

Hi — thanks for the request. Here's the breakdown of the items in your list; keep in mind that I currently don't support hooks in this plugin due to tricky-to-reproduce crashes when multiple plugins have hooks in play, so adding support for those here is out of scope.

  • Scag's VSH2-NoRegen plugin
    • CWeaponMedigun::AllowedToHealTarget and CTFPlayer::RegenThink have maintained entries in nosoop/SM-TFCustomAttributeStarterPack.
    • CObjectDispenser::CouldHealTarget does not, but I don't think it's worthwhile to have a native for that (as hooks aren't being considered).
  • Scag's Building Overhaul plugin
    • CBaseEntity::CalcAbsolutePosition seems generally useful. m_vecAbsOrigin doesn't get updated often depending on the item, such as weapons. I was planning on adding this in the future, actually.
    • I was also planning to implement CBaseCombatWeapon::CanAttack as well.
    • Otherwise, like before, everything else is either related to hooks or just seemingly not relevant to most plugins.
  • rafradek's Hidden Dev Attributes plugin
    • GetItemSchema and CEconItemSchema::GetAttributeDefinitionByName are maintained as part of TF2Attributes; I have maintainer access there so I should be able to respond quickly to updates.
    • Otherwise, it doesn't really have things that would be generally useful. I do have my own implementation of attribute injection that I've been meaning to release, however, which runs in native code instead of as a plugin (so it's more flexible, as it has full CUtl* container and KeyValues capabilities).

Since Scags hasn't archived those repositories, I'll go ahead and send in PRs for them shortly I've sent in PRs for them and they've been merged.

As I vaguely alluded to in the AlliedModders Discord, I do have an unlaunched, paid service where servers can automatically download gamedata updates (leaving it solely up to me to maintain them for the most part, which, being a higher level of obligation than the current state of "I'll update it if I feel like it", is why I'd want to be compensated).

If that is something you are interested in, do contact me on the forums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants