Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: publish docker images to github's registry #61

Merged
merged 15 commits into from
Sep 30, 2024
Merged

chore: publish docker images to github's registry #61

merged 15 commits into from
Sep 30, 2024

Conversation

melbeltagy
Copy link
Contributor

Refs: XRDCAT-28

Notes:

  • The flow can now be triggered either:
    • manually from here
    • or automatically after a successful build and test from develop
  • This action's fix (in this PR) have been used to generate these packages

@melbeltagy
chore: debug
11a08b0 
Refs: XRDCAT-28
@melbeltagy
chore: only run the publish pipeline manually
491d9f7 
Refs: XRDCAT-28
@melbeltagy
chore: change context and add file to docker action
675e192 
Refs: XRDCAT-28
@melbeltagy
chore: enable collector only (temporarily)
9dea598 
Refs: XRDCAT-28
@melbeltagy
chore: fix docker file's path
768e09a 
Refs: XRDCAT-28
@melbeltagy
chore: try using different base image
0ec0667 
Refs: XRDCAT-28
@melbeltagy
chore: return to alpine
9c538af 
Refs: XRDCAT-28
@melbeltagy
chore: add lister image back
8b19432 
Refs: XRDCAT-28
@melbeltagy
chore: build images after each other
3241996 
Refs: XRDCAT-28
@melbeltagy
fix: Fix clean old images job's name
a39279c 
Refs: XRDCAT-28
@melbeltagy
chore: remove unused env variable in publish_images.yaml
d9e05d0 
Refs: XRDCAT-28
@melbeltagy
chore: upgrade container-retention-policy action to version 3.0.0
2dbce4a 
Refs: XRDCAT-28
@melbeltagy
chore: remove debug info (working directory)
5524dd0 
Refs: XRDCAT-28
@melbeltagy
chore: fix after upgrade container-retention-policy action to v3.0.0
afdeda6 
Refs: XRDCAT-28
@melbeltagy
chore: update conditions when the action is triggered
46151ed 
Refs: XRDCAT-28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

X-Road-Catalog tests :: BuildAndTest
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
x-road-catalog
buildEnvironment xroad-catalog-persistence:buildEnvironment…
 8.10 ✅ Build Scan not published
x-road-catalog build 8.10 ❌ Build Scan not published

1 similar comment
@github-actions GitHub Actions
Copy link

Job Summary for Gradle

X-Road-Catalog tests :: BuildAndTest
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
x-road-catalog
buildEnvironment xroad-catalog-persistence:buildEnvironment…
 8.10 ✅ Build Scan not published
x-road-catalog build 8.10 ❌ Build Scan not published

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

X-Road-Catalog tests :: BuildAndTest
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
x-road-catalog
buildEnvironment xroad-catalog-persistence:buildEnvironment…
 8.10 ✅ Build Scan not published
x-road-catalog build 8.10 ✅ Build Scan not published

@melbeltagy melbeltagy requested review from a team and ovidijusnortal and removed request for a team September 29, 2024 18:39
ovidijusnortal
ovidijusnortal approved these changes Sep 30, 2024
View reviewed changes
Copy link

@ovidijusnortal ovidijusnortal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@melbeltagy melbeltagy merged commit fd6f70a into develop Sep 30, 2024
5 checks passed
@melbeltagy melbeltagy deleted the XRDCAT-28-docker-images-fix4 branch September 30, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovidijusnortal ovidijusnortal ovidijusnortal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melbeltagy @ovidijusnortal