Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use separate users for collector service, lister service, and liquibase with corresponding permissions #36

Merged
merged 19 commits into from
Jul 17, 2024

Conversation

melbeltagy
Copy link
Contributor

Refs: XRDCAT-4

Copy link

Job Summary for Gradle

X-Road-Catalog tests :: BuildAndTest
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
x-road-catalog build test 8.7 Build Scan not published

# Conflicts:
#	docker/collector/config/catalogdb-production.properties.sample
#	xroad-catalog-collector/src/main/resources/catalogdb-production.properties
#	xroad-catalog-collector/src/main/resources/db/changelog/db.changelog-master.xml
#	xroad-catalog-lister/src/main/resources/lister-production.properties
#	xroad-catalog-lister/src/main/resources/lister.properties
Copy link

Job Summary for Gradle

X-Road-Catalog tests :: BuildAndTest
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
x-road-catalog build test 8.7 Build Scan not published

Copy link

Job Summary for Gradle

X-Road-Catalog tests :: BuildAndTest
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
x-road-catalog build test 8.7 Build Scan not published

Copy link

Job Summary for Gradle

X-Road-Catalog tests :: BuildAndTest
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
x-road-catalog build test 8.7 Build Scan not published

@melbeltagy melbeltagy marked this pull request as ready for review July 16, 2024 19:27
@melbeltagy melbeltagy requested review from a team, mloitm and enelir and removed request for a team and mloitm July 16, 2024 19:28
@melbeltagy melbeltagy requested review from a team and mikkbachmann and removed request for enelir and a team July 16, 2024 19:32
@@ -1,24 +1,15 @@
logging.level.org.springframework.web=DEBUG
logging.level.org.springframework.ws=DEBUG
logging.level.org.hibernate=ERROR
# Hibernate log configuration
logging.level.org.hibernate.SQL=TRACE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking just in case - is it okay to leave these TRACE logging levels in, in a file that has 'production' in its name? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Removed them

Copy link

Copy link

Job Summary for Gradle

X-Road-Catalog tests :: BuildAndTest
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
x-road-catalog build test 8.7 Build Scan not published

@melbeltagy melbeltagy merged commit 4d082e7 into develop Jul 17, 2024
3 checks passed
@melbeltagy melbeltagy deleted the XRDCAT-4-separate-users branch July 17, 2024 13:15
@melbeltagy melbeltagy restored the XRDCAT-4-separate-users branch July 17, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants