feat: Proxy memory allocation helper #2605
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovidijusnortal
requested review from
a team and
ricardas-buc
and removed request for
a team
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
mloitm
reviewed
Feb 5, 2025
| if [ -z "$params" ]; then | ||
| echo "$1=$xms $xmx" >> "$params_file" | ||
| else | ||
| local pattern="-Xms[0-9]+[mg]" |
There was a problem hiding this comment.
According to documentation, Xmx and Xms can also be set in k or in plain bytes. Also unit suffix should be case insensitive.
mloitm
reviewed
Feb 5, 2025
|
|
||
| function find_xmx() { | ||
| if [[ "$1" =~ -Xmx([0-9]+[mg]) ]]; then | ||
| echo "${BASH_REMATCH[1]}" |
There was a problem hiding this comment.
-Xmx can be specified multiple times, the last one is used. To make things even more complicated, there's also equivalent -XX:MaxHeapSize
There was a problem hiding this comment.
@mloitm about k and just units, my thinking was that for proxy nobody will use such small units when 512m is declared as minimum unless someone will want to allocate very precise amount of memory
Initial implementation Refs: XRDDEV-55
This reverts commit ad32823bfc51c294efb8ee7fe76fce260a635f33.
Refs: XRDDEV-55
fix redhat build Refs: XRDDEV-55
ovidijusnortal
force-pushed
the
XRDDEV-55
branch
from
2d45594 to
fd181ac
Compare
|
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.