Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from pycodestyle to ruff as a linter #111

Merged
merged 20 commits into from
Nov 1, 2024
Merged

Switch from pycodestyle to ruff as a linter #111

merged 20 commits into from
Nov 1, 2024

Conversation

melbeltagy
Copy link
Contributor

  • Enhance building the modules locally
  • Enhance running them locally
  • Apply ruff rules as a code linter and fix couple of issues. (rules are not totally fixed and not enforced yet).

Refs: OPMONDEV-181

melbeltagy added 8 commits May 13, 2024 11:34
@melbeltagy melbeltagy requested a review from raits May 13, 2024 08:43
raits
raits requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@raits raits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just a few small remarks.

anonymizer_module/setup.py Outdated Show resolved Hide resolved
docs/collector_module.md Outdated Show resolved Hide resolved
docs/collector_module.md Outdated Show resolved Hide resolved
opendata_module/setup.py Outdated Show resolved Hide resolved
@raits
Copy link
Contributor

raits commented May 13, 2024

It would also be good to figure out what has broken the anonymizer tests and fix them.

@melbeltagy
fix: Fix PR's review comments
3c6a8a5 
Refs: OPMONDEV-181
@melbeltagy melbeltagy mentioned this pull request May 14, 2024
Merged
@melbeltagy
Copy link
Contributor Author

It would also be good to figure out what has broken the anonymizer tests and fix them.

anonymizer tests are fixed as part of PR #112

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@melbeltagy melbeltagy marked this pull request as draft May 15, 2024 09:23
@melbeltagy melbeltagy changed the title Enhancing building and running different modules locally Switch from pycodestyle to ruff as a linter May 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarCloud

@melbeltagy melbeltagy marked this pull request as ready for review November 1, 2024 10:48
raits
raits approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@raits raits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@melbeltagy melbeltagy merged commit b80e2cd into develop Nov 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raits raits raits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melbeltagy @raits