Corrector optimization #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hello @VitaliStupin! Thank you for the pull request, we will review it as soon as possible. |
Performing sanitise_document and correct_structure in worker threads instead of main thread. Computations in main thread can use only one CPU core and therefore negatively impact corrector throughput.
Deleting duplicates in threads instead of returning to_remove_queue and slowly processing that in main thread Deleting code that was broken and no longer used after corrector started matching documents by xRequestId: * Removing check if document marked as duplicate exists in clean_data because duplicates get deleted in any case * Removing special handling for duplicate documents without requestInTs Removed addition of deleted raw documents count to the total number of documents processed as these were already part of processed batch
Corrector did not check if processed document already exists in clean_data after corrector started matching documents by xRequestId. Adding duplicate detection.
Using multiprocessing for updating status of orphans that reached timeout. Fetching only document ids instead of full documents.
Using multiprocessing for processing of documents without xRequestId. Adding documents without xRequestId to total number of documents processed.
Corrector is currently using slow and deprecated (mozilla/bleach#698) bleach. Based on the fact that X-Road metrics should not contain HTML it would be more beneficial to just use python translate method and replace potentially dangerous HTML characters. Translate does not parse html and estimated to be 100 times faster than bleach. Using translate method instead of bleach.clean. Renaming sanitise -> sanitize to be consistent with the rest of the code.
melbeltagy
force-pushed
the
corrector-optimization
branch
from
23a8d23 to
28637e1
Compare
|
melbeltagy
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrector is currently using multiprocessing only for raw data processing, and many tasks are preformed in a single main thread that can use only one CPU core and therefore negatively impact corrector throughput.
This pull request optimizes corrector to increase throughput. Additionally a check if processed document already exists in clean_data is added (this check existed before last corrector rewrite, but was broken since that time).