Fix duplicate logging #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hello @VitaliStupin, Thank you for your contribution. We will take a look at it as soon as we can. |
Currently check `handler is WatchedFileHandler` always fails and a new handler is added every time _setup_logger is called. For example corrector logs every line three times. A fix for opendata was added with pull request nordic-institute#14 This commit makes the same change in all the other services.
melbeltagy
force-pushed
the
logger-handler-fix
branch
from
04376ac to
9f0c807
Compare
|
melbeltagy
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently check
handler is WatchedFileHandleralways fails and a new handler is added every time _setup_logger is called.For example corrector logs every line three times.
A fix for opendata was added with pull request #14
This commit makes the same change in all the other services.