Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add clazy to linting workflow #3125

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
attempt to fix Qt 6.4 build
cebtenzzre committed Oct 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 830f698365c6b6d9eaf160dadde64ede5b526ed1
5 changes: 4 additions & 1 deletion gpt4all-chat/src/chat.cpp
Original file line number Diff line number Diff line change
@@ -14,10 +14,13 @@
#include <QStringList>
#include <QVariant>
#include <Qt>
#include <QtLogging>

#include <utility>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

Chat::Chat(QObject *parent)
: QObject(parent)
, m_id(Network::globalInstance()->generateUniqueId())
5 changes: 4 additions & 1 deletion gpt4all-chat/src/chatapi.cpp
Original file line number Diff line number Diff line change
@@ -16,10 +16,13 @@
#include <QVariant>
#include <Qt>
#include <QtGlobal>
#include <QtLogging>

#include <iostream>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

using namespace Qt::Literals::StringLiterals;

//#define DEBUG
5 changes: 4 additions & 1 deletion gpt4all-chat/src/chatlistmodel.h
Original file line number Diff line number Diff line change
@@ -16,7 +16,10 @@
#include <QVector>
#include <Qt>
#include <QtGlobal>
#include <QtLogging>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

class ChatsRestoreThread : public QThread
{
5 changes: 4 additions & 1 deletion gpt4all-chat/src/chatllm.cpp
Original file line number Diff line number Diff line change
@@ -24,7 +24,6 @@
#include <QUrl>
#include <QWaitCondition>
#include <Qt>
#include <QtLogging>

#include <algorithm>
#include <cctype>
@@ -37,6 +36,10 @@
#include <utility>
#include <vector>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

using namespace Qt::Literals::StringLiterals;

//#define DEBUG
5 changes: 4 additions & 1 deletion gpt4all-chat/src/database.cpp
Original file line number Diff line number Diff line change
@@ -24,13 +24,16 @@
#include <QUtf8StringView>
#include <QVariant>
#include <Qt>
#include <QtLogging>

#include <algorithm>
#include <cmath>
#include <optional>
#include <stdexcept>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

using namespace Qt::Literals::StringLiterals;
namespace ranges = std::ranges;
namespace us = unum::usearch;
5 changes: 4 additions & 1 deletion gpt4all-chat/src/download.cpp
Original file line number Diff line number Diff line change
@@ -27,13 +27,16 @@
#include <QVariant>
#include <QVector>
#include <Qt>
#include <QtLogging>

#include <algorithm>
#include <compare>
#include <cstddef>
#include <utility>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

using namespace Qt::Literals::StringLiterals;

class MyDownload: public Download { };
5 changes: 4 additions & 1 deletion gpt4all-chat/src/embllm.cpp
Original file line number Diff line number Diff line change
@@ -22,12 +22,15 @@
#include <QUrl>
#include <Qt>
#include <QtGlobal>
#include <QtLogging>

#include <exception>
#include <utility>
#include <vector>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

using namespace Qt::Literals::StringLiterals;

static const QString EMBEDDING_MODEL_NAME = u"nomic-embed-text-v1.5"_s;
5 changes: 4 additions & 1 deletion gpt4all-chat/src/llm.cpp
Original file line number Diff line number Diff line change
@@ -11,7 +11,10 @@
#include <QProcess>
#include <QSettings>
#include <QUrl>
#include <QtLogging>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

#ifdef GPT4ALL_OFFLINE_INSTALLER
# include <QDesktopServices>
6 changes: 5 additions & 1 deletion gpt4all-chat/src/logger.h
Original file line number Diff line number Diff line change
@@ -3,7 +3,11 @@

#include <QFile>
#include <QString>
#include <QtLogging>
#include <QtGlobal>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

class Logger
{
5 changes: 4 additions & 1 deletion gpt4all-chat/src/modellist.cpp
Original file line number Diff line number Diff line change
@@ -32,7 +32,6 @@
#include <QTextStream>
#include <QTimer>
#include <QUrl>
#include <QtLogging>

#include <algorithm>
#include <cstddef>
@@ -41,6 +40,10 @@
#include <string>
#include <utility>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

using namespace Qt::Literals::StringLiterals;

//#define USE_LOCAL_MODELSJSON
6 changes: 5 additions & 1 deletion gpt4all-chat/src/mysettings.cpp
Original file line number Diff line number Diff line change
@@ -15,13 +15,17 @@
#include <QThread>
#include <QUrl>
#include <QVariant>
#include <QtLogging>
#include <QtGlobal>

#include <algorithm>
#include <string>
#include <thread>
#include <vector>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

using namespace Qt::Literals::StringLiterals;

// used only for settings serialization, do not translate
5 changes: 4 additions & 1 deletion gpt4all-chat/src/network.cpp
Original file line number Diff line number Diff line change
@@ -29,14 +29,17 @@
#include <QSysInfo>
#include <Qt>
#include <QtGlobal>
#include <QtLogging>
#include <QUrl>
#include <QUuid>

#include <cmath>
#include <cstring>
#include <utility>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

#ifdef __GLIBC__
# include <gnu/libc-version.h>
#endif
4 changes: 3 additions & 1 deletion gpt4all-chat/src/server.cpp
Original file line number Diff line number Diff line change
@@ -26,7 +26,6 @@
#include <Qt>
#include <QtCborCommon>
#include <QtGlobal>
#include <QtLogging>

#include <cstdint>
#include <iostream>
@@ -37,6 +36,9 @@
#include <unordered_map>
#include <utility>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif
#if QT_VERSION >= QT_VERSION_CHECK(6, 8, 0)
# include <QTcpServer>
#endif
5 changes: 4 additions & 1 deletion gpt4all-chat/src/xlsxtomd.cpp
Original file line number Diff line number Diff line change
@@ -16,10 +16,13 @@
#include <QStringView>
#include <QVariant>
#include <QtGlobal>
#include <QtLogging>

#include <memory>

#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
# include <QtLogging>
#endif

using namespace Qt::Literals::StringLiterals;