Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Slides + History bug #7425

Closed
5 of 6 tasks
dmaus opened this issue Mar 27, 2024 · 1 comment
Closed
5 of 6 tasks

Virtual Slides + History bug #7425

dmaus opened this issue Mar 27, 2024 · 1 comment
Labels

Comments

@dmaus
Copy link

dmaus commented Mar 27, 2024

Check that this is really a bug

  • I confirm

Reproduction link

https://codesandbox.io/p/devbox/swiper-vue-virtual-slides-history-rmghlx?file=%2Fsrc%2FApp.vue%3A13%2C18

Bug description

When jumping to a virtual slide (click a button under the slider) it throws an error:
runtime-core.esm-bundler.js:221 Uncaught TypeError: Cannot read properties of null (reading 'getAttribute')
It's not able to get the attribute "data-history" from the slide in the history code.

History changes only show in preview mode: https://rmghlx-5173.csb.app/

Expected Behavior

Showing the history of the slide in the browser url

Actual Behavior

Not changing the history, because it does not get the attribute "data-history"

Swiper version

11.0.7

Platform/Target and Browser Versions

macOS Chrome 121.0.6167.184 (Official Build) (x86_64)

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@dmaus dmaus added the Vue label Mar 27, 2024
@nolimits4web
Copy link
Owner

Vue version is not maintained, use core version or web component

Repository owner locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants