fix: add object arrays #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahm
reviewed
Mar 2, 2024
| @@ -3,7 +3,7 @@ import { klona as clone } from "klona/json"; | |||
|
|
|||
| type JsonValue = boolean | number | string | null; | |||
|
|
|||
| type Json = JsonValue | JsonValue[] | { [key: string]: Json }; | |||
| type Json = JsonValue | JsonValue[] | { [key: string]: Json } | Json[]; | |||
There was a problem hiding this comment.
May I suggest simply importing and using the Jsonifiable type from the type-fest package? That will cover other edge cases for you like objects with a toJson method, and read-only arrays which both would be rejected by this type.
There was a problem hiding this comment.
Tested locally and the Jsonifiable type works. @Hoishin thoughts?
There was a problem hiding this comment.
Adding package just for this simple type is overkill for me. Edge cases you mentioned don't happen in this case.
Hoishin
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously passing useReplicant an array of objects as the type it would fail even though that is valid JSON. This adds
Json[]to the Json type to allow for this.I also added a type to the test case.