Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pre-package libs into browser version #89

Closed
RubenVerborgh opened this issue Nov 9, 2018 · 5 comments
Closed

Don't pre-package libs into browser version #89

RubenVerborgh opened this issue Nov 9, 2018 · 5 comments

Comments

@RubenVerborgh
Copy link
Contributor

Instead of 3eb6b2d, we can also do https://github.com/defunctzombie/package-browser-field-spec#replace-specific-files---advanced

@RubenVerborgh
Copy link
Contributor Author

@rubensworks This did not work; I assume because @trust/webcrypto is a transitive dependency.

@rubensworks
Copy link
Contributor

Hmm, that's too bad.

Perhaps it can be solved by either:

@RubenVerborgh
Copy link
Contributor Author

@rubensworks Very probably; however, we don't want to touch the @trust libraries for now. (They seem to have an issue on this though: anvilresearch/webcrypto#57) Maybe I can have a look at getting rid of them altogether in favor of https://www.npmjs.com/package/isomorphic-webcrypto.

@RubenVerborgh
Copy link
Contributor Author

@rubensworks
Copy link
Contributor

Oh, so that's exactly what we need then :-)

isomorphic-webcrypto seems up-to-date with @trust/webcrypto, so it should be low-effort to transition to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants