Skip to content

Commit

Permalink
feat(dcellar-web-ui): fix the issue with browser cache getObjectMeta …
Browse files Browse the repository at this point in the history
…API & upgrade nextjs (#382)

* fix(dcellar-web-ui): upgrade nextjs to aviod attacks via CVE-2024-34351 vulnerability

* fix(dcellar-web-ui): fix the issue with browser cache getObjectMeta API

* docs(dcellar-web-ui): update changelog
  • Loading branch information
devinxl authored May 11, 2024
1 parent 5e2c017 commit 3f3df03
Show file tree
Hide file tree
Showing 5 changed files with 98 additions and 67 deletions.
15 changes: 15 additions & 0 deletions apps/dcellar-web-ui/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
{
"name": "dcellar-web-ui",
"entries": [
{
"version": "1.3.1",
"tag": "dcellar-web-ui_v1.3.1",
"date": "Sat, 11 May 2024 03:15:50 GMT",
"comments": {
"patch": [
{
"comment": "Upgrade nextjs to aviod attacks via CVE-2024-34351 vulnerability"
},
{
"comment": "Fix the issue with browser cache getObjectMeta API"
}
]
}
},
{
"version": "1.3.0",
"tag": "dcellar-web-ui_v1.3.0",
Expand Down
10 changes: 9 additions & 1 deletion apps/dcellar-web-ui/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
# Change Log - dcellar-web-ui

This log was last generated on Fri, 10 May 2024 08:02:26 GMT and should not be manually modified.
This log was last generated on Sat, 11 May 2024 03:15:50 GMT and should not be manually modified.

## 1.3.1
Sat, 11 May 2024 03:15:50 GMT

### Patches

- Upgrade nextjs to aviod attacks via CVE-2024-34351 vulnerability
- Fix the issue with browser cache getObjectMeta API

## 1.3.0
Fri, 10 May 2024 08:02:26 GMT
Expand Down
6 changes: 3 additions & 3 deletions apps/dcellar-web-ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dcellar-web-ui",
"version": "1.3.0",
"version": "1.3.1",
"private": false,
"scripts": {
"dev": "node ./scripts/dev.js -p 3200",
Expand Down Expand Up @@ -34,7 +34,7 @@
"dayjs": "^1.11.7",
"ethers": "^5.7.2",
"lodash-es": "^4.17.21",
"next": "~14.1.0",
"next": "~14.1.1",
"query-string": "^8.1.0",
"react": "~18.2.0",
"react-dom": "~18.2.0",
Expand Down Expand Up @@ -80,7 +80,7 @@
"eslint-config-prettier": "~9.1.0",
"@typescript-eslint/eslint-plugin": "~7.0.2",
"@typescript-eslint/parser": "~7.0.2",
"eslint-config-next": "~14.1.0",
"eslint-config-next": "~14.1.1",
"eslint-plugin-react": "~7.33.2"
},
"lint-staged": {
Expand Down
40 changes: 24 additions & 16 deletions apps/dcellar-web-ui/src/facade/object.ts
Original file line number Diff line number Diff line change
Expand Up @@ -621,22 +621,30 @@ export const getObjectMeta = async (
objectName,
)}?object-meta`;

return axios.get(url).then(
(e) => {
const data = xmlParser.parse(e.data)?.GfSpGetObjectMetaResponse.Object as ObjectMeta;
return [data, null];
},
(e) => {
const { response } = e;
if (!response) return [null, { code: 500, message: 'Oops, something went wrong' }];

const error =
response?.status === 429
? { code: response.status, message: 'SP not available. Try later.' }
: { message: xmlParser.parse(response.data)?.Error?.Message, code: response.status };
return [null, error];
},
);
return axios
.get(url, {
headers: {
'Cache-Control': 'no-cache',
Pragma: 'no-cache',
Expires: '0',
},
})
.then(
(e) => {
const data = xmlParser.parse(e.data)?.GfSpGetObjectMetaResponse.Object as ObjectMeta;
return [data, null];
},
(e) => {
const { response } = e;
if (!response) return [null, { code: 500, message: 'Oops, something went wrong' }];

const error =
response?.status === 429
? { code: response.status, message: 'SP not available. Try later.' }
: { message: xmlParser.parse(response.data)?.Error?.Message, code: response.status };
return [null, error];
},
);
};

export const getObjectVersions = async (id: string): Promise<ObjectVersion[]> => {
Expand Down
94 changes: 47 additions & 47 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3f3df03

Please sign in to comment.