Merge upstream master at 51907e0 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah squash merging here is going to create problems: our branch will always show as behind the usptream master. This and #20 should really use merge commits, I think. I know some people find merge commit objectionable, and they certainly can create ugly history if not managed well, but I think for long-lived branches that you are merging like this, they really are the right call. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges from upstream at dmlc@51907e0.
Had to revert ba73133, which adds usage of an API that isn't in a stable PyTorch release yet. Original attempt to do this cleanly was #17. The remaining changes look like all Python which shouldn't be a problem. I tested that a full debug build passes all C++ and Python unit tests (non-distributed).