Merge upstream master at 51907e0 #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh nevermind. dmlc#7855 switches to an API that isn't available till PyTorch 2.6 AFAICT (pytorch/pytorch@b14269d), which isn't even the stable release. |
|
I'm going to revert it locally. I'd rather have deprecation warnings for someone using a nightly release than not be buildable with the stable release. (although I sympathize. Deprecation warnings are really annoying. You can just build with |
|
Reverts are annoying to track with merge commits though because they count as having been merged in, so it will create a persistent diff. A problem for another day though. |
|
Since I'll need local changes, it's going to require a new PR. |
GMNGeoffrey
added a commit
that referenced
this pull request
Jan 29, 2025
Merges from upstream at dmlc@51907e0. Had to revert ba73133, which adds usage of an API that isn't in a stable PyTorch release yet. Original attempt to do this cleanly was #17. The remaining changes look like all Python which shouldn't be a problem. I tested that a full debug build passes all C++ and Python unit tests (non-distributed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges from upstream at dmlc@51907e0.
I don't see anything that should create problems.