Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] Let single handle flexible filter #607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[api] Let single handle flexible filter #607

wants to merge 1 commit into from

Conversation

anyj0527
Copy link
Member

@anyj0527 anyj0527 commented Feb 5, 2025

  • Let single API handle flexible filter.

@anyj0527
[api] Let single handle flexible filter
1674c69 
- Let single API handle flexible filter.

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
myungjoo
myungjoo reviewed Feb 17, 2025
View reviewed changes
c/src/ml-api-inference-single.c
* Set invoke_dynamic as TRUE if the given nnfw do invoke_dynamic
*
* if (info->nnfw == ML_NNFW_TYPE_EXECUTORCH_LLAMA || info->nnfw == ML_NNFW_TYPE_LLAMACPP) {
* invoke_dynamic = TRUE;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be set by the subplugin or pipeline user, not by the API implementation.
The API implementation (and nnstreamer core) should NOT aware such details.

songgot
songgot approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo myungjoo left review comments

@songgot songgot songgot approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anyj0527 @myungjoo @songgot @jaeyun-jung