More freedom for incrementor.enums.values regex

[uberkael]

Thanks for this extension.
I want to do something a bit more complex, like toggle between comparators or booleans operators, something like this

"incrementor.enums.values": [
	...
	[ "==", "!=" ],
	[ "&&", "||" ].
	[ ">", "<", ">=", "<=" ],
	[ "+", "-", "*", "/", "%" ],
	[ "++", "--" ],
	[ "!", "~" ],
	[ "&", "|", "^", "<<", ">>" ],
	[ "&&=", "||=", "+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>="],
]

The problem is the regular expression for is too restrictive:

"incrementor.enums.values": {
	"type": "array",
	"items": {
		"type": "array",
		"items": {
			"type": "string",
			"pattern": "^\\w(?:\\-?\\w+)*$"
		}
	},
	...

It is possible to change "^\\w(?:\\-?\\w+)*$" to "^\\S(?:\\-?\\S+)*$" ? Maybe is a breaking change.
I can make a PR if is accepted.

[nmsmith22389]

Thanks for the feedback! I really want to get this extension back in working order so any help in the form of PRs you can offer would be greatly appreciated.

I'll have to double check the code to see if everything still functions without much regex restriction.

[nmsmith22389]

Do you think adding some of the more popular ones as features (like togglable options) would be better?

Actually I'm thinking it's probably best to just have a custom list with some defaults set. (Aside from the numbers)

[uberkael]

Probably my regex won't work with [ "++", "--" ] or [ "!", "~"] in normal cases like i++ or !check.
I will try make a PR tomorrow.

Thanks.

[uberkael]

I have created a Pull Request with the code and included a video. #44
It seems to work with a few minor adjustments.
However, I wasn't able to run tests for all scenarios, as testing in extensions is not my thing.

vokoscreenNG-2024-10-11_02-32-00.mp4

[nmsmith22389]

Good work!

From the video it seems to work well but I can also try it out locally to be sure.

I think I might have to do some research to see if there's a better way to select what the extension needs without getting confused in situations like the ones you described.

But either way I'll try out your PR and if it works well locally I can merge it. Thanks again!