Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist: headjack #8

Closed
1 task done
kaitj opened this issue Nov 18, 2024 · 2 comments
Closed
1 task done

Checklist: headjack #8

kaitj opened this issue Nov 18, 2024 · 2 comments
Labels
approved Approval for tool checklist checklist Denote checklist submission

Comments

@kaitj
Copy link
Collaborator

kaitj commented Nov 18, 2024

Checklist content

{
  "name": "headjack",
  "urls": [
    {
      "url_type": "Landing page",
      "url": "https://github.com/childmindresearch/headjack"
    }
  ],
  "documentation": {
    "bronze": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": true,
      "7": true,
      "8": true,
      "9": true
    },
    "silver": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": true
    },
    "gold": {
      "1": false,
      "2": false,
      "3": false,
      "4": true,
      "5": false,
      "6": false
    }
  },
  "infrastructure": {
    "bronze": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": false,
      "7": true
    },
    "silver": {
      "1": false,
      "2": false,
      "3": true
    },
    "gold": {
      "1": true,
      "2": false,
      "3": false,
      "4": false,
      "5": false
    }
  },
  "testing": {
    "bronze": {
      "1": false,
      "2": false
    },
    "silver": {
      "1": false,
      "2": false
    },
    "gold": {
      "1": false,
      "2": false
    }
  }
}

Additional information

No response

Agreement

  • I agree
@kaitj kaitj added the checklist Denote checklist submission label Nov 18, 2024
@LuciMoore
Copy link
Collaborator

LuciMoore commented Nov 27, 2024

The final review for this has been performed. Additional notes from the final reviewer:

  • Does cargo.lock need to be under source code control? It’s a generated file.

I've copied the original checklist json below and will update the json above with the checklist from the final review before marking as approved

{
  "name": "headjack",
  "urls": [
    {
      "url_type": "Landing page",
      "url": "https://github.com/childmindresearch/headjack"
    }
  ],
  "documentation": {
    "bronze": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": true,
      "7": true,
      "8": true,
      "9": true
    },
    "silver": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": true
    },
    "gold": {
      "1": false,
      "2": false,
      "3": false,
      "4": true,
      "5": false,
      "6": false
    }
  },
  "infrastructure": {
    "bronze": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": false,
      "7": true
    },
    "silver": {
      "1": false,
      "2": false,
      "3": true
    },
    "gold": {
      "1": true,
      "2": false,
      "3": false,
      "4": false,
      "5": false
    }
  },
  "testing": {
    "bronze": {
      "1": false,
      "2": false
    },
    "silver": {
      "1": false,
      "2": false
    },
    "gold": {
      "1": false,
      "2": false
    }
  }
}

@LuciMoore LuciMoore added the approved Approval for tool checklist label Nov 27, 2024
github-actions bot added a commit that referenced this issue Nov 27, 2024
@kaitj
Copy link
Collaborator Author

kaitj commented Dec 2, 2024

Manually closing this - commit comment should have closed this.

Also cc: @nx10 for awareness of comments

@kaitj kaitj closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approval for tool checklist checklist Denote checklist submission
Projects
None yet
Development

No branches or pull requests

2 participants