Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace in max_coverage #65

Closed
carbonmetrics opened this issue Jul 19, 2018 · 1 comment
Closed

namespace in max_coverage #65

carbonmetrics opened this issue Jul 19, 2018 · 1 comment

Comments

@carbonmetrics
Copy link

max_coverage does not run without loading dplyr.
max_coverage contains function extract_mc_results in line 156,
and that function calls bind_rows in line 45 - I guess dplyr::bind_rows would solve the issue.

as an aside - why did you implement this in dplyr? data.table is much faster.

@njtierney
Copy link
Owner

Hello!

Thank you for picking up on the namespace issue! This has now been fixed.

I am interested in making maxcovr faster in the future, data.table will be considered at a later release (#68), but for the moment there are other changes that I would like to make. I would welcome a PR for using data.table if you are interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants