fix: posix_spawn returns errno on error, not -1 #2595
Merged
+16
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
According to the POSIX man page:
Error::result()
assumes the function returns -1 on error, so it won't work here.Actually, this is my fault 🤦♂️, the implementation in PR #2007 handled this correctly, but my erroneous review comment led the PR in the wrong direction.
Also, since
posix_spawn()
usesfork()
(can be other syscalls depending on the impl) under the hood, its tests should grab theFORK_MTX
lock.Checklist:
CONTRIBUTING.md
These 2 posx_spawn*() interfaces have not been released, so no changelog needed.