Skip to content

Commit

Permalink
lib/types/gpt: do not hard-code alignment to 2048 sectors
Browse files Browse the repository at this point in the history
On 4Kn disks, 2048-sector alignment is equivalent to 8 MiB which is
excessive. Moreover, there is no point in specifying _any_ alignment
at all because sgdisk defaults to 1 MiB already.

Fixes #497.
  • Loading branch information
intelfx authored and mergify[bot] committed Jan 14, 2024
1 parent f78b649 commit 036d480
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/types/gpt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ in
default = ''
${lib.concatStrings (map (partition: ''
sgdisk \
--set-alignment=2048 \
--align-end \
--new=${toString partition._index}:${partition.start}:${partition.end} \
--change-name=${toString partition._index}:${partition.label} \
Expand Down

0 comments on commit 036d480

Please sign in to comment.