-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add users
option to both GitHub and Gitea restricting project owners
#394
base: main
Are you sure you want to change the base?
Conversation
19f150e
to
30abfe1
Compare
Signed-off-by: magic_rb <richard@brezak.sk>
507b5ed
to
1d57aab
Compare
Tested removing the topic and using only the repoAllowlist in nix-community, adding/removing repos works, did need to change the - topic = "nix-community-buildbot";
+ repoAllowlist = [
+ "nix-community/authentik-nix"
+ "nix-community/autofirma-nix"
+ "nix-community/dream2nix"
+ "nix-community/ethereum.nix"
+ "nix-community/infra"
+ "nix-community/lanzaboote"
+ "nix-community/neovim-nightly-overlay"
+ "nix-community/nix-direnv"
+ "nix-community/nix-index"
+ "nix-community/nix4nvchad"
+ "nix-community/NixNG"
+ "nix-community/nixos-facter"
+ "nix-community/nixos-facter-modules"
+ "nix-community/nixos-generators"
+ "nix-community/nixos-images"
+ "nix-community/nixpkgs-update"
+ "nix-community/nixpkgs-xr"
+ "nix-community/nixvim"
+ "nix-community/raspberry-pi-nix"
+ "nix-community/srvos"
+ ]; diff --git a/nix/master.nix b/nix/master.nix
index 2a75c8f74..3a3fc8854 100644
--- a/nix/master.nix
+++ b/nix/master.nix
@@ -374,7 +374,7 @@ in
};
topic = lib.mkOption {
type = lib.types.nullOr lib.types.str;
- default = "build-with-buildbot";
+ default = null;
description = ''
Projects that have this topic will be built by buildbot.
If null, all projects that the buildbot Gitea user has access to, are built.
@@ -453,7 +453,7 @@ in
};
topic = lib.mkOption {
type = lib.types.nullOr lib.types.str;
- default = "build-with-buildbot";
+ default = null;
description = ''
Projects that have this topic will be built by buildbot.
If null, all projects that the buildbot github user has access to, are built. |
You should be able to just set it to null no? I think that building everything by default is not a good idea. |
I think this was just for testing not intended as the new default. |
userAllowlist = lib.mkOption { | ||
type = lib.types.nullOr (lib.types.listOf lib.types.str); | ||
default = null; | ||
description = "If non-null, specifies users/organizations that are allowed to use buildbot, i.e. buildbot-nix will ignore any repositories not owned by these users/organizations."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention here that this in addition to the buildbot github topic?
Was kind of thinking of a new default. Could have an assert requiring that one or more of topic, userAllowlist, repoAllowlist is set? But maybe not be worth the disruption for other users. |
Hopefully closes #393