fix(dev): use os tmp dir for unix sockets #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nitrojs with
|
| Latest commit: |
a78b8ad
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f5816146.nitrojs.pages.dev |
| Branch Preview URL: | https://fix-dev-usock.nitrojs.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #2997 fix for 2.11 with a different solution
issue was that, if one linux user stating a nitro server, it was creating
/tmp/nitro/with permissions for that specific user and any other user would be blocked.By moving socket to local build dir, we solved this issue but also introduced more possibilities that if permissions of build dir is mixed (used by two users), it causes more issues.
Since after iterations in 2.11, we are now generating an almost reliable unique socket name, we can use
/tmp/nitro-{name}.sockinstead.