Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ariaTSsetup input to text file #71

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ehavazli
Copy link
Collaborator

Added the functionality to write product paths to a text file and changed the ariaTSsetup.py input to text file.
Previous method of using wildcards is preserved but commented out.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@EJFielding
Copy link
Collaborator

Hi @ehavazli, Can you look at the changes that are in @katia-tymofyeyeva PR #69 ? She modified the ariaTSsetup call to use a date selection section that Adrian wrote. It should be possible to do the text file creation that you are suggesting but also do the date selection. It seems that ariaTSsetup does not have its own date selection like ariaDownload has.

@ehavazli
Copy link
Collaborator Author

Hi @ehavazli, Can you look at the changes that are in @katia-tymofyeyeva PR #69 ? She modified the ariaTSsetup call to use a date selection section that Adrian wrote. It should be possible to do the text file creation that you are suggesting but also do the date selection. It seems that ariaTSsetup does not have its own date selection like ariaDownload has.

Thank you for pointing out that PR @EJFielding, I am going to update this PR after @katia-tymofyeyeva merges that one.

@ehavazli
Copy link
Collaborator Author

@EJFielding @rzinke @katia-tymofyeyeva
I incorporated the final changes from Adrian to this PR and changed the -nt 16 to -nt 8 just to be sure that the user has enough CPU's available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants