Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] 3.17.0 #420

Merged
merged 76 commits into from
Mar 2, 2023
Merged

[Release] 3.17.0 #420

merged 76 commits into from
Mar 2, 2023

Conversation

ryan-conway
Copy link
Collaborator

@ryan-conway ryan-conway commented Mar 1, 2023 •
edited
Loading

lydiasama and others added 30 commits January 26, 2023 18:59
@lydiasama
[#159] Add DataStore to sample-compose
728d66e
@lydiasama
[#159] Add DataStore use cases to sample-compose
48c9968
@lydiasama
[#159] Refactor and hide loading when there is error
6281037
@lydiasama
[#159] Wrap flow with flowTransform and use the .first() to get only …
4f6601c 
…first emit from datastore
@lydiasama
[#159] Change back to simple flow to avoid mapping error unnecessary
e433ce8
@lydiasama
[#159] Set allow backup to false to avoid preferences caching after u…
3ed8173 
…ninstalling app, refactor code
@toby-thanathip
[Chore] Bump version to 3.17.0
ea444ce
@toby-thanathip
Merge pull request #395 from nimblehq/chore/bump-version-3.17.0
12651e5 
[Chore] Bump version to 3.17.0
@luongvo
[#354] [Sample] Add HomeViewModelTest
4103389
@luongvo
[#354] [Template] Add HomeViewModelTest
4455248
@luongvo
[#354] [Sample] Add initial HomeScreenTest
e08c082
@luongvo
[#354] [Template] Add initial HomeScreenTest
86094bc
@luongvo
[#354] Grant permission by default for UI tests
b89a97f
@luongvo
[#354] Add more tests to HomeScreenTest with mockk
56a354c
@luongvo
[#354] [Sample] Create initComposable to optimize composeRule usage i…
22692b7 
…n each test case
@lydiasama
[#159] Rename variable, re-indentation code
e7acff2
@lydiasama
Merge branch 'develop' into feature/159-part2-support-datastore-repla…
5fa297a 
…cing-shared-preference

# Conflicts:
#	sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/screens/home/HomeScreen.kt
[#394] Update ANDROID_VERSION_NAME variable
b204725
[#394] Update Perl command to find the correct variable
34f02bd
@luongvo
[#354] Reorder dependencies
dc12149
[#394] Remove ids and they are redundant
90de0cc
[#379] Auto adding label when creating issue
473ee3f
@lydiasama
[#159] Code refactoring
69eb119
@lydiasama
[#159] Rename module
68d7608
[#379] Auto adding label type when creating bug/chore/feature
6cc45df
@toby-thanathip
Merge pull request #400 from nimblehq/bug/394-fix-bump-version
23b5c3a 
[#394] Fix bump version workflow
@toby-thanathip
Merge pull request #404 from nimblehq/chore/379-add-labels-template
e6380e2 
[#379] Update issue templates to automatically included the correct labels
@lydiasama
[#159] Add unit tests for use cases
6dbe671
@lydiasama
[#159] Rename argument
a69c549
@lydiasama
[#159] Get rid of redundant line break
3547c7b
@ryan-conway ryan-conway self-assigned this Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023 •
edited
Loading

7 Warnings
⚠️ Big PR
⚠️ Uh oh! BaseViewModel.kt is under 95% coverage!
⚠️ Uh oh! HomeFragment.kt is under 95% coverage!
⚠️ Uh oh! HomeViewModel.kt is under 95% coverage!
⚠️ Uh oh! UiModel.kt is under 95% coverage!
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ Uh oh! HomeScreen.kt is under 95% coverage!

Kover report for template-xml:

🧛 Template - XML Unit Tests Code Coverage: 34.00%

Coverage of Modified Files:

File Coverage
AppPreferencesRepositoryImpl.kt 100.00%
BaseViewModel.kt 0.00%
HomeFragment.kt 92.96%
HomeViewModel.kt 0.00%
UiModel.kt 0.00%
UseCase.kt 100.00%

Modified Files Not Found In Coverage Report:

AndroidManifest.xml
AndroidManifest.xml
AppPreferencesRepository.kt
AppPreferencesRepository.kt
AppPreferencesRepository.kt
AppPreferencesRepository.kt
AppPreferencesRepositoryImplTest.kt
AppPreferencesRepositoryImplTest.kt
AppPreferencesRepositoryImplTest.kt
AppPreferencesRepositoryImplTest.kt
AppShapes.kt
CODEOWNERS
CoroutineTestRule.kt
CoroutineTestRule.kt
HomeScreen.kt
HomeScreenTest.kt
HomeScreenTest.kt
HomeScreenTest.kt
HomeViewModelTest.kt
HomeViewModelTest.kt
IsFirstTimeLaunchPreferencesUseCase.kt
IsFirstTimeLaunchPreferencesUseCase.kt
IsFirstTimeLaunchPreferencesUseCaseTest.kt
IsFirstTimeLaunchPreferencesUseCaseTest.kt
PreferencesModule.kt
PreferencesModule.kt
PreferencesModule.kt
PreferencesModule.kt
RELEASE_TEMPLATE.md
RepositoryTest.kt
RepositoryTest.kt
StorageModule.kt
StorageModule.kt
StorageModule.kt
StorageModule.kt
TestDispatchersProvider.kt
UpdateFirstTimeLaunchPreferencesUseCase.kt
UpdateFirstTimeLaunchPreferencesUseCase.kt
UpdateFirstTimeLaunchPreferencesUseCaseTest.kt
UpdateFirstTimeLaunchPreferencesUseCaseTest.kt
UseCaseTest.kt
UseCaseTest.kt
UseCaseTest.kt
Versions.kt
Versions.kt
Versions.kt
Versions.kt
bug_template.md
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
bump_version.yml
chore_template.md
detekt-config.yml
detekt-config.yml
feature_template.md
robolectric.properties
robolectric.properties
version.properties

Codebase cunningly covered by count Shroud 🧛

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 61.00%

Coverage of Modified Files:

File Coverage
AppPreferencesRepositoryImpl.kt 100.00%
AppShapes.kt 100.00%
BaseViewModel.kt 97.62%
HomeScreen.kt 50.46%
HomeViewModel.kt 100.00%
UiModel.kt 84.21%
UseCase.kt 100.00%

Modified Files Not Found In Coverage Report:

AndroidManifest.xml
AndroidManifest.xml
AppPreferencesRepository.kt
AppPreferencesRepository.kt
AppPreferencesRepository.kt
AppPreferencesRepository.kt
AppPreferencesRepositoryImplTest.kt
AppPreferencesRepositoryImplTest.kt
AppPreferencesRepositoryImplTest.kt
AppPreferencesRepositoryImplTest.kt
CODEOWNERS
CoroutineTestRule.kt
CoroutineTestRule.kt
HomeFragment.kt
HomeScreenTest.kt
HomeScreenTest.kt
HomeScreenTest.kt
HomeViewModelTest.kt
HomeViewModelTest.kt
IsFirstTimeLaunchPreferencesUseCase.kt
IsFirstTimeLaunchPreferencesUseCase.kt
IsFirstTimeLaunchPreferencesUseCaseTest.kt
IsFirstTimeLaunchPreferencesUseCaseTest.kt
PreferencesModule.kt
PreferencesModule.kt
PreferencesModule.kt
PreferencesModule.kt
RELEASE_TEMPLATE.md
RepositoryTest.kt
RepositoryTest.kt
StorageModule.kt
StorageModule.kt
StorageModule.kt
StorageModule.kt
TestDispatchersProvider.kt
UpdateFirstTimeLaunchPreferencesUseCase.kt
UpdateFirstTimeLaunchPreferencesUseCase.kt
UpdateFirstTimeLaunchPreferencesUseCaseTest.kt
UpdateFirstTimeLaunchPreferencesUseCaseTest.kt
UseCaseTest.kt
UseCaseTest.kt
UseCaseTest.kt
Versions.kt
Versions.kt
Versions.kt
Versions.kt
bug_template.md
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
bump_version.yml
chore_template.md
detekt-config.yml
detekt-config.yml
feature_template.md
robolectric.properties
robolectric.properties
version.properties

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@luongvo
Copy link
Member

luongvo commented Mar 2, 2023

@ryan-conway Should we wait for the Part 3 #416 to complete the whole task for the release? cc @lydiasama

@ryan-conway
Copy link
Collaborator Author

@luongvo According to the repository maintainers handbook that @Tuubz created, releases should happen at the end of the cycle, meaning this release is already late as it should have been made on Feb 28. But if #416 does get merged today, I don't see why we shouldn't include it in this release 🙏🏻

@lydiasama
Copy link
Contributor

@luongvo @ryan-conway I'm on it now. 🙏🏻

lydiasama added 2 commits March 2, 2023 11:24
@lydiasama
[#159] Small refactor
ce9172a
@lydiasama
Merge branch 'develop' into feature/159-template-support-datastore-re…
6b35e89 
…placing-shared-preference

# Conflicts:
#	template-compose/buildSrc/src/main/java/Versions.kt
@ryan-conway
Merge pull request #416 from nimblehq/feature/159-template-support-da…
12c895c 
…tastore-replacing-shared-preference

[#159][Part 3][Template] Support datastore replacing shared preference
luongvo
luongvo approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@luongvo luongvo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryan-conway please list #159 in the release note.

@ryan-conway ryan-conway merged commit d5c905d into main Mar 2, 2023
@ryan-conway ryan-conway deleted the release/3.17.0 branch March 2, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AVI5HEK AVI5HEK AVI5HEK approved these changes

@lydiasama lydiasama lydiasama approved these changes

@luongvo luongvo luongvo approved these changes

@thiennguyen0196 thiennguyen0196 thiennguyen0196 approved these changes

@doannimble doannimble doannimble approved these changes

@chornerman chornerman Awaiting requested review from chornerman chornerman is a code owner

@hoangnguyen92dn hoangnguyen92dn Awaiting requested review from hoangnguyen92dn hoangnguyen92dn is a code owner

@kaungkhantsoe kaungkhantsoe Awaiting requested review from kaungkhantsoe kaungkhantsoe is a code owner

@manh-t manh-t Awaiting requested review from manh-t manh-t is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@sleepylee sleepylee Awaiting requested review from sleepylee sleepylee is a code owner

@toby-thanathip toby-thanathip Awaiting requested review from toby-thanathip toby-thanathip is a code owner

@Wadeewee Wadeewee Awaiting requested review from Wadeewee

Assignees

@ryan-conway ryan-conway

Labels
type : release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ryan-conway @luongvo @lydiasama @AVI5HEK @thiennguyen0196 @doannimble @toby-thanathip @Wadeewee