[#352] Apply some code reviews changes: navigation & LaunchedEffect u…

…sage
nimblehq · Dec 15, 2022 · d709212 · d709212
1 parent 1928900
commit d709212
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 72 deletions.
diff --git a/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/AppDestination.kt b/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/AppDestination.kt
@@ -16,13 +16,6 @@ sealed class AppDestination(val route: String = "") {
 
     object Home : AppDestination("home")
 
-    /**
-     * We can define route as "coin/details" without "coinId" parameter because we're passing it as argument already.
-     * So either passing "coinId" via arguments or passing it via route.
-     *
-     * We keep passing "coinId" in both route and arguments for this destination to give example of navigation concept
-     * about how to build a destination with parameters.
-     */
     object Second : AppDestination("second/{$KEY_ID}") {
 
         override val arguments = listOf(

diff --git a/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/AppNavigation.kt b/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/AppNavigation.kt
@@ -45,7 +45,7 @@ private fun NavGraphBuilder.composable(
 
 private fun NavHostController.navigate(destination: AppDestination) {
     when (destination) {
-        is AppDestination.Up -> popBackStack()
+        is AppDestination.Up -> navigateUp()
         else -> navigate(route = destination.destination)
     }
 }
diff --git a/...mpose/app/src/main/java/co/nimblehq/sample/compose/ui/screens/home/HomeComposeFragment.kt b/...mpose/app/src/main/java/co/nimblehq/sample/compose/ui/screens/home/HomeComposeFragment.kt
diff --git a/...compose/app/src/main/java/co/nimblehq/sample/compose/ui/screens/home/HomeComposeScreen.kt b/...compose/app/src/main/java/co/nimblehq/sample/compose/ui/screens/home/HomeComposeScreen.kt
@@ -25,13 +25,13 @@ fun HomeComposeScreen(
     navigator: (destination: AppDestination) -> Unit
 ) {
     val context = LocalContext.current
-    LaunchedEffect(Unit) {
+    LaunchedEffect(viewModel.error) {
         viewModel.error.collect { error ->
             val message = error.userReadableMessage(context)
             Toast.makeText(context, message, Toast.LENGTH_SHORT).show()
         }
     }
-    LaunchedEffect(viewModel) {
+    LaunchedEffect(viewModel.navigator) {
         viewModel.navigator.collect { destination -> navigator(destination) }
     }