[#354] We should use a verb to start a func name -> "setUp"

nimblehq · Feb 13, 2023 · c80193a · c80193a
1 parent e973b93
commit c80193a
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 8 deletions.
diff --git a/...ose/app/src/androidTest/java/co/nimblehq/sample/compose/ui/screens/home/HomeScreenTest.kt b/...ose/app/src/androidTest/java/co/nimblehq/sample/compose/ui/screens/home/HomeScreenTest.kt
@@ -36,7 +36,7 @@ class HomeScreenTest {
     private var expectedAppDestination: AppDestination? = null
 
     @Before
-    fun setup() {
+    fun setUp() {
         every { mockUseCase() } returns flowOf(
             listOf(Model(1), Model(2), Model(3))
         )

diff --git a/...e-compose/data/src/test/java/co/nimblehq/sample/compose/data/repository/RepositoryTest.kt b/...e-compose/data/src/test/java/co/nimblehq/sample/compose/data/repository/RepositoryTest.kt
@@ -10,9 +10,9 @@ import io.mockk.mockk
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.flow.catch
 import kotlinx.coroutines.flow.collect
+import kotlinx.coroutines.test.runTest
 import org.junit.Before
 import org.junit.Test
-import kotlinx.coroutines.test.runTest
 
 @ExperimentalCoroutinesApi
 class RepositoryTest {
@@ -23,7 +23,7 @@ class RepositoryTest {
     private val response = Response(id = 1)
 
     @Before
-    fun setup() {
+    fun setUp() {
         mockService = mockk()
         repository = RepositoryImpl(mockService)
     }

diff --git a/sample-compose/domain/src/test/java/co/nimblehq/sample/compose/domain/usecase/UseCaseTest.kt b/sample-compose/domain/src/test/java/co/nimblehq/sample/compose/domain/usecase/UseCaseTest.kt
@@ -3,7 +3,8 @@ package co.nimblehq.sample.compose.domain.usecase
 import co.nimblehq.sample.compose.domain.model.Model
 import co.nimblehq.sample.compose.domain.repository.Repository
 import io.kotest.matchers.shouldBe
-import io.mockk.*
+import io.mockk.every
+import io.mockk.mockk
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.flow.*
 import kotlinx.coroutines.test.runTest
@@ -19,7 +20,7 @@ class UseCaseTest {
     private val model = Model(id = 1)
 
     @Before
-    fun setup() {
+    fun setUp() {
         mockRepository = mockk()
         useCase = UseCase(mockRepository)
     }

diff --git a/...e/app/src/androidTest/java/co/nimblehq/template/compose/ui/screens/home/HomeScreenTest.kt b/...e/app/src/androidTest/java/co/nimblehq/template/compose/ui/screens/home/HomeScreenTest.kt
@@ -18,7 +18,7 @@ class HomeScreenTest {
     private var expectedAppDestination: AppDestination? = null
 
     @Before
-    fun setup() {
+    fun setUp() {
         composeRule.activity.setContent {
             HomeScreen(
                 navigator = { destination -> expectedAppDestination = destination }

diff --git a/...compose/data/src/test/java/co/nimblehq/template/compose/data/repository/RepositoryTest.kt b/...compose/data/src/test/java/co/nimblehq/template/compose/data/repository/RepositoryTest.kt
@@ -23,7 +23,7 @@ class RepositoryTest {
     private val response = Response(id = 1)
 
     @Before
-    fun setup() {
+    fun setUp() {
         mockService = mockk()
         repository = RepositoryImpl(mockService)
     }

diff --git a/...e-compose/domain/src/test/java/co/nimblehq/template/compose/domain/usecase/UseCaseTest.kt b/...e-compose/domain/src/test/java/co/nimblehq/template/compose/domain/usecase/UseCaseTest.kt
@@ -19,7 +19,7 @@ class UseCaseTest {
     private val model = Model(id = 1)
 
     @Before
-    fun setup() {
+    fun setUp() {
         mockRepository = mockk()
         useCase = UseCase(mockRepository)
     }