Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont create duplicated items #60

Open
brokelyn opened this issue May 11, 2023 · 4 comments
Open

Dont create duplicated items #60

brokelyn opened this issue May 11, 2023 · 4 comments
Labels
idea An idea that needs to be discussed
Milestone

Comments

@brokelyn
Copy link
Collaborator

If an item has the same name then it should be reused instead of created new

image

@brokelyn
Copy link
Collaborator Author

@nilsalm any idea how we would handle it with the different quantities?

@nilsalm
Copy link
Owner

nilsalm commented May 12, 2023

puh, i don't know. But I also think we're creating a problem out of thin air.
What's that real value of having an archive? Because this Issue is not an Issue without the archive and if the archive isn't really necessary then we could spend time on more important issues. I'm sceptical of the business/user value of having the archive view.

@nilsalm
Copy link
Owner

nilsalm commented May 15, 2023

I think I got an idea to solve this easily!! We change the Item-model and remove the picked-flag, But use the quantity as picked, so we only display items with quantity > 0 and if the user picks an item we set quantity = 0. Then, we could just find the "old" item and set the quantity to 1 when a user adds it again. This would reduce duplicates I suppose, but leaves the question whether this is of real value to the user or not.

@brokelyn
Copy link
Collaborator Author

Thats probalby a good idea. I like having this feature when adding new items so it can check if I am readding an item.
But if any item is always added again and again and again, we bloat the database for no reason. That maybe an even more interesting point

@nilsalm nilsalm added the idea An idea that needs to be discussed label May 31, 2023
@brokelyn brokelyn added this to the Phase 2 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea An idea that needs to be discussed
Projects
None yet
Development

No branches or pull requests

2 participants