New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: suggestions #5

Merged

nikhilsinhaparseable merged 4 commits into nikhilsinhaparseable:correlation-fix from de-sh:correlation-fix

Jan 17, 2025

de-sh commented Jan 17, 2025

Fixes #XXXX.

Description

This PR has:

been tested to ensure log ingestion and log query works.
added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
added documentation for new or modified features or behaviors.

de-sh added 4 commits

January 17, 2025 17:16


          refactor: unnest

73a8c84


          refactor: don't branch

4a3883f


          don't await collection

99978cf


          refactor: string construction

393d374

nikhilsinhaparseable merged commit 41f4cbd into nikhilsinhaparseable:correlation-fix

3 of 4 checks passed

de-sh deleted the correlation-fix branch

January 17, 2025 12:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet