Fix memory leak in phpdbg calling registered function

Closes phpGH-17635.
nielsdos · Jan 30, 2025 · 62bbfde · 62bbfde
1 parent 5447473
commit 62bbfde
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/NEWS b/NEWS
@@ -11,6 +11,7 @@ PHP                                                                        NEWS
 
 - PHPDBG:
   . Partially fixed bug GH-17387 (Trivial crash in phpdbg lexer). (nielsdos)
+  . Fix memory leak in phpdbg calling registered function. (nielsdos)
 
 13 Feb 2025, PHP 8.3.17
 

diff --git a/sapi/phpdbg/phpdbg_prompt.c b/sapi/phpdbg/phpdbg_prompt.c
@@ -189,6 +189,9 @@ static inline int phpdbg_call_register(phpdbg_param_t *stack) /* {{{ */
 
 			zval_ptr_dtor_str(&fci.function_name);
 			efree(lc_name);
+			if (fci.named_params) {
+				zend_array_destroy(fci.named_params);
+			}
 
 			return SUCCESS;
 		}

diff --git a/sapi/phpdbg/tests/register_function_leak.phpt b/sapi/phpdbg/tests/register_function_leak.phpt
@@ -0,0 +1,24 @@
+--TEST--
+registering a function and calling it leaks arguments memory
+--FILE--
+<?php
+echo "Done\n";
+?>
+--PHPDBG--
+register var_dump
+var_dump "a" "b"
+register flush
+flush
+r
+q
+--EXPECTF--
+[Successful compilation of %s]
+prompt> [Registered var_dump]
+prompt> string(1) "a"
+string(1) "b"
+
+prompt> [Registered flush]
+prompt> 
+prompt> Done
+[Script ended normally]
+prompt>
-Original file line number
+Diff line change
@@ Expand Up / @@ -11,6 +11,7 @@ PHP NEWS @@
     - PHPDBG:
       . Partially fixed bug GH-17387 (Trivial crash in phpdbg lexer). (nielsdos)
+      . Fix memory leak in phpdbg calling registered function. (nielsdos)
 Feb 2025, PHP 8.3.17
@@ Expand Down @@