runtime: check if a handle is a valid handle when pinning

Author: nickwanninger

runtime/core/HandleTable.cpp

@@ -135,7 +135,7 @@ namespace alaska {
     return m_slabs[idx];
   }
 
-  slabidx_t HandleTable::mapping_slab_idx(Mapping *m) {
+  slabidx_t HandleTable::mapping_slab_idx(Mapping *m) const {
     auto byte_distance = (uintptr_t)m - (uintptr_t)m_table;
     return byte_distance / HandleTable::slab_size;
   }
@@ -154,6 +154,10 @@ namespace alaska {
   }
 
 
+  bool HandleTable::valid_handle(Mapping *m) const {
+    return mapping_slab_idx(m) < (slabidx_t)m_slabs.size();
+  }
+
   void HandleTable::put(Mapping *m, alaska::ThreadCache *owner) {
     log_trace("Putting handle %p", m);
     // Validate that the handle is in this table

runtime/include/alaska/HandleTable.hpp

@@ -99,13 +99,15 @@ namespace alaska {
     alaska::HandleSlab *new_slab(ThreadCache *new_owner);
     alaska::HandleSlab *get_slab(slabidx_t idx);
     // Given a mapping, return the index of the slab it belongs to.
-    slabidx_t mapping_slab_idx(Mapping *m);
+    slabidx_t mapping_slab_idx(Mapping *m) const;
 
     auto slab_count() const { return m_slabs.size(); }
     auto capacity() const { return m_capacity; }
 
     void dump(FILE *stream);
 
+    bool valid_handle(alaska::Mapping *m) const;
+
 
     // Free/release *some* mapping
     void put(alaska::Mapping *m, alaska::ThreadCache *owner = (alaska::ThreadCache *)0x1000UL);

runtime/rt/barrier.cpp

@@ -20,6 +20,7 @@
 #include <alaska/utils.h>
 #include <alaska/alaska.hpp>
 #include <alaska/rt/barrier.hpp>
+#include <alaska/Runtime.hpp>
 
 
 #include <ck/lock.h>
@@ -175,6 +176,8 @@ static void record_handle(void* possible_handle, bool marked) {
   //   return;
   // }
 
+  if (not alaska::Runtime::get().handle_table.valid_handle(m)) return;
+
   if (m->is_free()) return;
 
   if (marked) printf("pinned %p\n", possible_handle);