adjust the handling of non-handle frees

Author: nickwanninger

runtime/core/ThreadCache.cpp

@@ -186,8 +186,11 @@ namespace alaska {
   void ThreadCache::hfree(void *handle) {
     alaska::Mapping *m = alaska::Mapping::from_handle_safe(handle);
     if (unlikely(m == nullptr)) {
+
+      // printf("attempt to free non handle %p\n", handle);
       bool worked = this->runtime.heap.huge_allocator.free(handle);
-      ALASKA_ASSERT(worked, "huge free failed");
+      (void)worked;
+      // ALASKA_ASSERT(worked, "huge free failed");
       return;
     }
     // Free the allocation behind a mapping
@@ -199,7 +202,10 @@ namespace alaska {
 
 
   size_t ThreadCache::get_size(void *handle) {
-    alaska::Mapping *m = alaska::Mapping::from_handle(handle);
+    alaska::Mapping *m = alaska::Mapping::from_handle_safe(handle);
+    if (m == nullptr) {
+      return this->runtime.heap.huge_allocator.size_of(handle);
+    }
     void *ptr = m->get_pointer();
     auto *page = this->runtime.heap.pt.get_unaligned(ptr);
     if (page == nullptr) return this->runtime.heap.huge_allocator.size_of(ptr);

runtime/rt/halloc.cpp

@@ -75,14 +75,6 @@ void hfree(void *ptr) {
   // no-op if NULL is passed
   if (unlikely(ptr == NULL)) return;
 
-  // Grab the Mapping
-  auto *m = alaska::Mapping::from_handle_safe(ptr);
-
-  // Not a handle? Pass it to the system allocator.
-  if (unlikely(m == NULL)) {
-    return ::free(ptr);
-  }
-
   // Simply ask the thread cache to free it!
   get_tc()->hfree(ptr);
 }