Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(system, data-frame): change term 'Metadata' to 'Properties' #83

Merged
merged 13 commits into from
Jan 16, 2025

Conversation

richie-ni
Copy link
Collaborator

@richie-ni richie-ni commented Oct 14, 2024

🤨 Rationale

US : User Story 2861034: Update "Metadata" to "Properties" in the existing Grafana datasources - Systems and Dataframes

This Pull Request involves the change of updating the term 'MetaData' to 'Properties' as discussed in the Products & Results DataSource Requirements PR, in the Systems and DataFrame DataSource to improve clarity and consistency. This also involves renaming the SystemMetadata type to SystemProperties across various files in the asset DataSource.

👩‍💻 Implementation

  • Renamed SystemMetadata to SystemProperties in the QuerySystemsResponse interface at src/core/types.ts
  • Updated variable names and constants from metadata instead of properties in all relevant files
  • Updated imports, function parameters, and test cases to use type SystemProperties instead of SystemMetadata in all relevant files.'.
  • Added logic to handle existing dashboards with the MetaData datatype

🧪 Testing

  • Test files have been updated with the term 'Properties' instead of 'MetaData' and verified manually that all tests are passing locally.

✅ Checklist

@richie-ni richie-ni changed the title feat(products): change term 'Metadata' to 'Properties' refactor(system, data-frame): change term 'Metadata' to 'Properties' Oct 15, 2024
@richie-ni richie-ni self-assigned this Oct 15, 2024
@richie-ni richie-ni requested a review from ranjgith-ni October 16, 2024 09:03
@mure
Copy link
Contributor

mure commented Oct 16, 2024

@richie-ni Is this ready to be reviewed? I see that it's in the "Draft" state.

@richie-ni
Copy link
Collaborator Author

richie-ni commented Oct 17, 2024

@richie-ni Is this ready to be reviewed? I see that it's in the "Draft" state.

@mure We wanted to get it reviewed internally, once done i will be moving the PR from the Draft state to Ready for review.

@richie-ni richie-ni marked this pull request as ready for review October 17, 2024 09:55
@richie-ni
Copy link
Collaborator Author

@mure , @kkerezsi, @CiprianAnton , @cameronwaterman Could you please review the changes in the PR?

@richie-ni richie-ni requested a review from ranjgith-ni January 7, 2025 07:15
@richie-ni richie-ni added the enhancement New feature or request label Jan 7, 2025
@richie-ni richie-ni requested a review from kkerezsi January 9, 2025 04:12
@richie-ni
Copy link
Collaborator Author

@kkerezsi , @mure , @CiprianAnton , @cameronwaterman could you please review the changes.

@CiprianAnton CiprianAnton requested a review from chotea January 13, 2025 08:06
@richie-ni richie-ni requested a review from kkerezsi January 13, 2025 10:39
@richie-ni richie-ni merged commit dbe40d5 into main Jan 16, 2025
1 check passed
@richie-ni richie-ni deleted the users/richie/metadata-to-properties branch January 16, 2025 04:35
@mure
Copy link
Contributor

mure commented Jan 24, 2025

🎉 This PR is included in version 3.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mure mure added the released label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants