Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asset): data link creation on deployed envs #108

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

saradei-ni
Copy link
Collaborator

@saradei-ni saradei-ni commented Oct 28, 2024

Pull Request

🀨 Rationale

Data links have different behavior on local environment.

πŸ‘©β€πŸ’» Implementation

Used config.appUrl from grafana runtime config in order to build the default url.

πŸ§ͺ Testing

Updated snapshots

βœ… Checklist

@saradei-ni saradei-ni force-pushed the users/saradei/2913391-v2 branch 2 times, most recently from 22a1690 to eaba53c Compare October 29, 2024 09:49
@saradei-ni saradei-ni force-pushed the users/saradei/2913391-v2 branch from eaba53c to ec3bd97 Compare October 29, 2024 09:56
@saradei-ni saradei-ni merged commit 11125b3 into main Oct 29, 2024
1 check passed
@saradei-ni saradei-ni deleted the users/saradei/2913391-v2 branch October 29, 2024 15:42
mure pushed a commit that referenced this pull request Oct 29, 2024
## [3.43.1](v3.43.0...v3.43.1) (2024-10-29)

### Bug Fixes

* **asset:** data link creation on deployed envs ([#108](#108)) ([11125b3](11125b3))
@mure
Copy link
Contributor

mure commented Oct 29, 2024

πŸŽ‰ This PR is included in version 3.43.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@mure mure added the released label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants